rocAL Serialize PR 2 : Introduce Argument class by fiona-gladwin · Pull Request #400 · ROCm/rocAL

fiona-gladwin · 2025-10-16T18:31:14Z

Motivation

Creates an argument instance for each arg passed in the Node
Handles different argument types i.e parameters, vectors, enums and predefined types

Technical Details

Creation of a Argument class with type-safe argument storage and processing
Implementation of template-based type detection system for various C++ types

NOTE: To be merged after PR #398

Remove the usage of API enums in internal node files

Add support to register all internal enums

Creates an argument instance for each arg passed in the Node Handles different argument types i.e parameters, vectors, enums and predefined types

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Create single constructor with check for different data types in Argument class

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

into fg/ser_argument

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…change

…ocAL into fg/ser_argument

spolifroni-amd

Needs one change to make sure it fits the changelog format

CHANGELOG.md

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

rocAL/include/pipeline/argument.h

rrawther

Added a comment

The merge-base changed after approval.

* Docs - updated the toc (#406) * rocAL Serialize PR 1- Introduce EnumRegistry (#398) * Use enums present in commons.h Remove the usage of API enums in internal node files * Remove unused include rocal_api_types.h * Introduce EnumRegistry Add support to register all internal enums * Remove redundant static cast Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove semicolon for enum macro * Modify name of macro * Change enums to scoped enums in commons.h * Minor fix * Remove unused includes * Add compiler keywords * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CMakeLists version for rocAL --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Fiona Gladwin <121928245+fgladwin@users.noreply.github.com> Co-authored-by: Sundar Rajan Vaithiyanathan <99159823+SundarRajan28@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * HIP - Set HIP device in output routine thread (#407) * Adding hipSetDevice in output routine thread * Remove whitespace Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Sundar Rajan Vaithiyanathan <svaithiy@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * rocAL Serialize PR 2 : Introduce Argument class (#400) * Use enums present in commons.h Remove the usage of API enums in internal node files * Remove unused include rocal_api_types.h * Introduce EnumRegistry Add support to register all internal enums * Introduce Argument class Creates an argument instance for each arg passed in the Node Handles different argument types i.e parameters, vectors, enums and predefined types * Remove redundant static cast Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove semicolon for enum macro * Modify name of macro * Change enums to scoped enums in commons.h * Code reorganization Create single constructor with check for different data types in Argument class * Minor fix * Remove unused includes * Add compiler keywords * Update rocAL/include/pipeline/argument.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update rocAL/include/pipeline/argument.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor change * Update rocAL/include/pipeline/argument.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update rocAL/include/pipeline/argument.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor change * Fix shared pointer fetching * Minor fix * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CMakeLists version for rocAL * Update CHANGELOG * Minor change * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Add const correctness to get args list --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Fiona Gladwin <121928245+fgladwin@users.noreply.github.com> Co-authored-by: Sundar Rajan Vaithiyanathan <99159823+SundarRajan28@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * Docs - removed opencl and added hip (#408) Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * Enable Lintian Support rocAL (#403) * fix lintian errors * remove overrides install, fix formatting * fix readme error * removing docs/README.md --------- Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.27.0 to 1.29.0 in /docs/sphinx (#416) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.27.0 to 1.29.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.27.0...v1.29.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.29.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - readding the readme (#417) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Bug fixes - HIP (#409) * Fix bug in CropResize node * Use HIP mem for fused crop rocjpeg decoder * Fix bug with ROI updation in numpy loader * Resolve review comments --------- Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Fiona-MCW <70996026+fiona-gladwin@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.29.0 to 1.30.0 in /docs/sphinx (#418) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.29.0 to 1.30.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.29.0...v1.30.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.30.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.30.0 to 1.30.1 in /docs/sphinx (#423) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.30.0 to 1.30.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.30.0...v1.30.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.30.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * rocAL Serialize PR 3 : Introduce PipelineOperator class (#401) * Use enums present in commons.h Remove the usage of API enums in internal node files * Remove unused include rocal_api_types.h * Introduce EnumRegistry Add support to register all internal enums * Introduce Argument class Creates an argument instance for each arg passed in the Node Handles different argument types i.e parameters, vectors, enums and predefined types * Introduce PipelineOperator class * Add support to create and return node name and tensor name * Add support in MasterGraph to store details of PipelineOperators * Add support to store the argument details in the node for brightness and ImageLoaderNode * Remove redundant static cast Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove semicolon for enum macro * Modify name of macro * Change enums to scoped enums in commons.h * Code reorganization Create single constructor with check for different data types in Argument class * Minor fix * Remove unused includes * Add compiler keywords * Update rocAL/include/pipeline/argument.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update rocAL/include/pipeline/argument.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor change * Update rocAL/include/pipeline/argument.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update rocAL/include/pipeline/argument.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor change * Fix shared pointer fetching * Minor fix * Minor fix * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CMakeLists version for rocAL * Update CHANGELOG * Update CHANGELOG.md * Minor change * Minor changes * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Add const qualifier * Add const correctness to get args list * Minor change * Add const correctness to get args list * Update CHANGELOG * Generate UID for tensors from MasterGraph * Minor change * Resolve copilot review comments * Minor change * Minor changes --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Fiona Gladwin <121928245+fgladwin@users.noreply.github.com> Co-authored-by: Sundar Rajan Vaithiyanathan <99159823+SundarRajan28@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * CMakeLists - Update GPU targets (#421) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * multi channel dataloader - example/sample (#415) * Update numpy reader example * Add new example and remove changes from other example * Update comment * Remove unused import Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Resolve review comments --------- Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> Co-authored-by: Fiona-MCW <70996026+fiona-gladwin@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Sundar Rajan Vaithiyanathan <svaithiy@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Docs - Update CHANGELOG.md (#424) * Update CHANGELOG.md Updates for 7.2 * Changelog - bugfixes --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Fiona-MCW <70996026+fiona-gladwin@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Fiona Gladwin <121928245+fgladwin@users.noreply.github.com> Co-authored-by: Sundar Rajan Vaithiyanathan <99159823+SundarRajan28@users.noreply.github.com> Co-authored-by: Sundar Rajan Vaithiyanathan <svaithiy@amd.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> Co-authored-by: jonatluu <jonatluu@amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fiona-gladwin and others added 30 commits September 22, 2025 02:30

Use enums present in commons.h

c4e55ca

Remove the usage of API enums in internal node files

Remove unused include rocal_api_types.h

22af55b

Introduce EnumRegistry

752a734

Add support to register all internal enums

Introduce Argument class

6d45638

Creates an argument instance for each arg passed in the Node Handles different argument types i.e parameters, vectors, enums and predefined types

Remove redundant static cast

cba503f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Remove semicolon for enum macro

604ce6a

Modify name of macro

ef53616

Change enums to scoped enums in commons.h

bb665e5

Merge branch 'fg/enum_register' into fg/ser_argument

1f11c53

Code reorganization

d9d527e

Create single constructor with check for different data types in Argument class

Minor fix

2651138

Remove unused includes

68dc5d3

Add compiler keywords

da2ae16

Merge branch 'fg/enum_change' into fg/enum_register

db854ce

Merge branch 'fg/enum_register' into fg/ser_argument

ca0a736

Update rocAL/include/pipeline/argument.h

a1979c2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update rocAL/include/pipeline/argument.h

48730ba

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'develop' into fg/enum_change

d05dd31

Merge branch 'develop' into fg/enum_register

478e019

Merge branch 'fg/ser_argument' of https://github.com/fiona-gladwin/rocAL

df36a72

into fg/ser_argument

Minor change

6b97bcb

Update rocAL/include/pipeline/argument.h

8f361bb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update rocAL/include/pipeline/argument.h

c6212ca

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Minor change

57dfa73

Fix shared pointer fetching

55640dd

Minor fix

f0a5e49

Update CHANGELOG.md

58d98fe

Merge branch 'fg/enum_change' into fg/enum_register

e268b10

Update CHANGELOG.md

ae86648

Merge branch 'develop' of https://github.com/ROCm/rocAL into fg/enum_…

bfb4b7e

…change

fiona-gladwin and others added 4 commits October 16, 2025 12:36

Merge branch 'develop' into fg/enum_register

5052fd6

Merge branch 'fg/enum_register' of https://github.com/fiona-gladwin/r…

aa91eed

…ocAL into fg/ser_argument

Update CHANGELOG

df3f598

Minor change

d2ccaab

fiona-gladwin requested review from a team, kiritigowda and rrawther as code owners October 16, 2025 18:31

LakshmiKumar23 self-requested a review October 17, 2025 16:40

spolifroni-amd requested changes Oct 17, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

fiona-gladwin and others added 2 commits October 22, 2025 17:09

Update CHANGELOG.md

37fe4be

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

Add const correctness to get args list

d9ce6c9

fiona-gladwin mentioned this pull request Oct 22, 2025

rocAL Serialize PR 3 : Introduce PipelineOperator class #401

Merged

spolifroni-amd previously approved these changes Oct 22, 2025

View reviewed changes

LakshmiKumar23 added New Feature ci:precheckin labels Oct 24, 2025

LakshmiKumar23 assigned kiritigowda Oct 24, 2025

Merge branch 'develop' into fg/ser_argument

dbb5573

rrawther reviewed Oct 29, 2025

View reviewed changes

rocAL/include/pipeline/argument.h Show resolved Hide resolved

rrawther requested changes Oct 29, 2025

View reviewed changes

Merge branch 'develop' into fg/ser_argument

3f2d467

rrawther previously approved these changes Nov 5, 2025

View reviewed changes

Merge branch 'develop' into fg/ser_argument

3fb45cb

LakshmiKumar23 requested a review from rrawther November 5, 2025 23:19

rrawther approved these changes Nov 5, 2025

View reviewed changes

LakshmiKumar23 approved these changes Nov 5, 2025

View reviewed changes

Merge branch 'develop' into fg/ser_argument

fe8f33e

LakshmiKumar23 merged commit 24d9524 into ROCm:develop Nov 10, 2025
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rocAL Serialize PR 2 : Introduce Argument class#400

rocAL Serialize PR 2 : Introduce Argument class#400
LakshmiKumar23 merged 51 commits intoROCm:developfrom
fiona-gladwin:fg/ser_argument

fiona-gladwin commented Oct 16, 2025

Uh oh!

spolifroni-amd left a comment

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

fiona-gladwin commented Oct 16, 2025

Motivation

Technical Details

Uh oh!

spolifroni-amd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants