Skip to content

rocAL DecoderType enum change#378

Merged
kiritigowda merged 5 commits intoROCm:developfrom
fiona-gladwin:dec_enum_change
Sep 19, 2025
Merged

rocAL DecoderType enum change#378
kiritigowda merged 5 commits intoROCm:developfrom
fiona-gladwin:dec_enum_change

Conversation

@fiona-gladwin
Copy link
Copy Markdown
Contributor

@fiona-gladwin fiona-gladwin commented Sep 11, 2025

Motivation

Test Plan

No new tests added

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rocAL/source/api/rocal_api_data_loaders.cpp 96.88% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #378      +/-   ##
===========================================
- Coverage    80.67%   80.67%   -0.00%     
===========================================
  Files          274      274              
  Lines        21078    21078              
===========================================
- Hits         17004    17003       -1     
- Misses        4074     4075       +1
Files with missing lines Coverage Δ
...L/include/decoders/audio/audio_decoder_factory.hpp 75.00% <100.00%> (ø)
rocAL/include/decoders/image/decoder.h 76.47% <ø> (ø)
rocAL/include/decoders/image/fused_crop_decoder.h 80.00% <100.00%> (ø)
rocAL/include/decoders/image/open_cv_decoder.h 42.86% <100.00%> (ø)
rocAL/include/decoders/image/rocjpeg_decoder.h 24.11% <100.00%> (ø)
...nclude/decoders/image/rocjpeg_fused_crop_decoder.h 40.00% <100.00%> (ø)
rocAL/include/decoders/image/turbo_jpeg_decoder.h 40.00% <100.00%> (ø)
rocAL/source/decoders/image/decoder_factory.cpp 56.00% <100.00%> (ø)
...AL/source/decoders/video/video_decoder_factory.cpp 66.67% <100.00%> (ø)
rocAL/source/loaders/image/image_loader.cpp 94.35% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kiritigowda kiritigowda merged commit fcf785f into ROCm:develop Sep 19, 2025
9 checks passed
shahamed pushed a commit that referenced this pull request Oct 7, 2025
@fiona-gladwin @kiritigowda
DecoderType enum - updates (#378)
356d32a 
* Remove trailing _DEC in enum name

* Change is_partial_decoder to is_cropped_decoder

* Minor fix

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
jharryma pushed a commit that referenced this pull request Oct 10, 2025
@kiritigowda @spolifroni-amd
@fiona-gladwin @dependabot
ROCm 7.1 cherry-pick - Fixes and updates required for 7.1 (#392)
125d1e4 
* Docs - removing SP6 (#379)

* DecoderType enum -  updates (#378)

* Remove trailing _DEC in enum name

* Change is_partial_decoder to is_cropped_decoder

* Minor fix

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Changed the link to MIVisionX openVX install (#381)

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.23.0 to 1.24.1 in /docs/sphinx (#384)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.23.0 to 1.24.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.24.1/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.23.0...v1.24.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.24.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#385)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Packaging - HIP deps updates (#387)

* Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#388)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* ROCm 7.1 - Changelog updates (#391)

* Docs - Add Jax to the rocAL (ROCm 7.1) (#386)

* refactored in preparation for adding jax

* fixed wording and typos

* fixed a wrong branch

* added jax content; rolled back conf.py changes; refactored the sections

* changed master branch to develop

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Fiona-MCW <70996026+fiona-gladwin@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LakshmiKumar23 LakshmiKumar23 LakshmiKumar23 approved these changes

@kiritigowda kiritigowda Awaiting requested review from kiritigowda kiritigowda is a code owner

@rrawther rrawther Awaiting requested review from rrawther rrawther is a code owner

Assignees

@kiritigowda kiritigowda

Labels

ci:precheckin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fiona-gladwin @LakshmiKumar23 @kiritigowda