Skip to content

Refactor cmake files for loading ROCm libs#302

Merged
iotamudelta merged 1 commit intoROCm:masterfrom
jithunnair-amd:cleanup_ROCm_cmake_files
Nov 1, 2018
Merged

Refactor cmake files for loading ROCm libs#302
iotamudelta merged 1 commit intoROCm:masterfrom
jithunnair-amd:cleanup_ROCm_cmake_files

Conversation

@jithunnair-amd
Copy link
Copy Markdown
Collaborator

rocfft should also be linked in to libcaffe2_hip.so. Combined build for caffe2 and pytorch means all dependencies should be linked in.

@jithunnair-amd
Copy link
Copy Markdown
Collaborator Author

@pytorchbot retest this please

@iotamudelta iotamudelta merged commit c9e771a into ROCm:master Nov 1, 2018
@iotamudelta iotamudelta added the cherry-picked This pull request has been cherry-picked into pytorch/pytorch upstream. label Jan 14, 2019
amd-sriram pushed a commit that referenced this pull request Mar 2, 2026
Commit Messages:
- Update release notes for clarity and conciseness (#311)

Removed redundant information and clarified release notes.
- Add new apex module to jit load system (#294) (#302)

* add code to add loader module for jit module

* fix errors to create jit module adder - use correct file name to save code to

* fix errors to create jit module adder - use correct class name of the builder and parameter to supply builder module name

* fix errors to create jit module loader

* add description about jit module script to add jit loader for a jit module with builder provided

* add description about jit module script to add jit loader for a jit module with builder provided

* add attributes and methods to override when creating a jit module builder

* add extra new lines

* update jit module to take the builder file name and extract module name from the builder, update missing entries in the table in readme for adding new module in jit

* refine the description about module to jit

* add description about jit

* add description about jit

* add code to create a builder based on user inputs

* change the example from fused_dense to swiglu

* allow user to skip sources list

* change description of cxx and nvcc flags, add description of methods and fields in the initial builder code created by script

PRs:
- ROCm/apex#311

Fixes:
- https://example.com/issue-294
- https://example.com/issue-311
- https://example.com/issue-302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked This pull request has been cherry-picked into pytorch/pytorch upstream.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants