Refactor cmake files for loading ROCm libs#302
Merged
iotamudelta merged 1 commit intoROCm:masterfrom Nov 1, 2018
Merged
Conversation
…ked in to libcaffe2_hip.so
Collaborator
Author
|
@pytorchbot retest this please |
iotamudelta
approved these changes
Nov 1, 2018
amd-sriram
pushed a commit
that referenced
this pull request
Mar 2, 2026
Commit Messages: - Update release notes for clarity and conciseness (#311) Removed redundant information and clarified release notes. - Add new apex module to jit load system (#294) (#302) * add code to add loader module for jit module * fix errors to create jit module adder - use correct file name to save code to * fix errors to create jit module adder - use correct class name of the builder and parameter to supply builder module name * fix errors to create jit module loader * add description about jit module script to add jit loader for a jit module with builder provided * add description about jit module script to add jit loader for a jit module with builder provided * add attributes and methods to override when creating a jit module builder * add extra new lines * update jit module to take the builder file name and extract module name from the builder, update missing entries in the table in readme for adding new module in jit * refine the description about module to jit * add description about jit * add description about jit * add code to create a builder based on user inputs * change the example from fused_dense to swiglu * allow user to skip sources list * change description of cxx and nvcc flags, add description of methods and fields in the initial builder code created by script PRs: - ROCm/apex#311 Fixes: - https://example.com/issue-294 - https://example.com/issue-311 - https://example.com/issue-302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocfft should also be linked in to libcaffe2_hip.so. Combined build for caffe2 and pytorch means all dependencies should be linked in.