[release/2.4][ROCm][TunableOp] Fix TunableOp warmup environment variable. (#147412)#2017
Merged
pruthvistony merged 1 commit intorelease/2.4from Apr 21, 2025
Merged
Conversation
…#147412) This PR corrects the behavior of the TunableOp warmup variables: ``` PYTORCH_TUNABLEOP_MAX_WARMUP_DURATION_MS PYTORCH_TUNABLEOP_MAX_WARMUP_ITERATIONS ``` See the updated comments which describe how the environment variables are intended to work. Previously, if you only set one of the two environment variables the warmup iters would always be zero. Manually tested the four possible combinations to make sure things still behavior as intended. Pull Request resolved: pytorch#147412 Approved by: https://github.com/jeffdaily (cherry picked from commit 4b35139)
Author
|
This is a subtle bug that has been present for a while. I discovered it post PyTorch 2.6 release. Cherry picked from upstream and will need to be cherry picked into ROCm 2.5 and 2.6 release branches. |
|
Jenkins build for a9992d4cd7685b64a1ca9c419925b6bcd19de1ef commit finished as SUCCESS |
|
Jenkins build for a9992d4cd7685b64a1ca9c419925b6bcd19de1ef commit finished as FAILURE |
pruthvistony
approved these changes
Apr 21, 2025
Author
|
!cherry-pick --onto release/2.5 |
rocm-mici
pushed a commit
that referenced
this pull request
Apr 21, 2025
…ble. (pytorch#147412) (#2017) This PR corrects the behavior of the TunableOp warmup variables: ``` PYTORCH_TUNABLEOP_MAX_WARMUP_DURATION_MS PYTORCH_TUNABLEOP_MAX_WARMUP_ITERATIONS ``` See the updated comments which describe how the environment variables are intended to work. Previously, if you only set one of the two environment variables the warmup iters would always be zero. Manually tested the four possible combinations to make sure things still behavior as intended. Pull Request resolved: pytorch#147412 Approved by: https://github.com/jeffdaily (cherry picked from commit 4b35139)
|
Created branch autogenerated/release/2.5_cherry-pick_pr-2017 and #2040 |
Author
|
!cherry-pick --onto release/2.6 |
rocm-mici
pushed a commit
that referenced
this pull request
Apr 21, 2025
…ble. (pytorch#147412) (#2017) This PR corrects the behavior of the TunableOp warmup variables: ``` PYTORCH_TUNABLEOP_MAX_WARMUP_DURATION_MS PYTORCH_TUNABLEOP_MAX_WARMUP_ITERATIONS ``` See the updated comments which describe how the environment variables are intended to work. Previously, if you only set one of the two environment variables the warmup iters would always be zero. Manually tested the four possible combinations to make sure things still behavior as intended. Pull Request resolved: pytorch#147412 Approved by: https://github.com/jeffdaily (cherry picked from commit 4b35139)
|
Created branch autogenerated/release/2.6_cherry-pick_pr-2017 and #2042 |
jithunnair-amd
pushed a commit
that referenced
this pull request
Apr 22, 2025
…nvironment variable. (pytorch#147412) (#2040) Cherry-pick of #2017 Co-authored-by: Nichols A. Romero <165712832+naromero77amd@users.noreply.github.com>
jithunnair-amd
pushed a commit
that referenced
this pull request
Apr 22, 2025
…nvironment variable. (pytorch#147412) (#2042) Cherry-pick of #2017 Co-authored-by: Nichols A. Romero <165712832+naromero77amd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the behavior of the TunableOp warmup variables:
See the updated comments which describe how the environment variables are intended to work. Previously, if you only set one of the two environment variables the warmup iters would always be zero.
Manually tested the four possible combinations to make sure things still behavior as intended.
Pull Request resolved: pytorch#147412
Approved by: https://github.com/jeffdaily
(cherry picked from commit 4b35139)