Bump AOTriton to 0.8.2b#1853
Merged
xinyazhang merged 1 commit intorelease/2.5from Jan 24, 2025
Merged
Conversation
Fixes SWDEV-508774
|
Jenkins build for f0af20f97e8706c37c6f8a4bfeb9683bf239183a commit finished as FAILURE |
jeffdaily
approved these changes
Jan 23, 2025
jithunnair-amd
pushed a commit
that referenced
this pull request
Feb 19, 2025
…pport ========================================================================== Let aotriton.cmake detect the best binary package to use, and deprecate aotriton_version.txt (pytorch#137443) We do not need `install_aotriton.sh` and `aotriton_version.txt` any more since `aotriton.cmake` now installs the best binary release package as the default option when building pytorch. This should resolve the issue of needing a pre-installed aotriton package when building PyTorch for ROCm from source, which is not feasible if building PyTorch *outside* a CI docker image. With this change, a user can have a pre-installed AOTriton in their environment, if desired, and have the build pick it up by specifying the `AOTRITON_INSTALLED_PREFIX` env var, or have the build automatically detect and install the compatible version. As a third option, the user can also force AOTriton to build from source instead, using the `AOTRITON_INSTALL_FROM_SOURCE` env var. Also, with the changes in this PR, the cmake build process handles the tasks of copying aotriton .so and images directory from `torch/lib` to the installation path. Pull Request resolved: pytorch#137443 Approved by: https://github.com/jithunnair-amd, https://github.com/jeffdaily Co-authored-by: Jithun Nair <jithun.nair@amd.com> (cherry picked from commit bc57635) Bump AOTriton to 0.8.2b (#1853) Fixes SWDEV-508774 (cherry picked from commit 4bed249) Enable head_dim == 512 with AOTriton 0.8.1 (cherry picked from commit 6edd36f) Add unit tests for head dimension 512 (cherry picked from commit 85290fa)
jithunnair-amd
pushed a commit
that referenced
this pull request
Feb 20, 2025
…pport ========================================================================== Let aotriton.cmake detect the best binary package to use, and deprecate aotriton_version.txt (pytorch#137443) We do not need `install_aotriton.sh` and `aotriton_version.txt` any more since `aotriton.cmake` now installs the best binary release package as the default option when building pytorch. This should resolve the issue of needing a pre-installed aotriton package when building PyTorch for ROCm from source, which is not feasible if building PyTorch *outside* a CI docker image. With this change, a user can have a pre-installed AOTriton in their environment, if desired, and have the build pick it up by specifying the `AOTRITON_INSTALLED_PREFIX` env var, or have the build automatically detect and install the compatible version. As a third option, the user can also force AOTriton to build from source instead, using the `AOTRITON_INSTALL_FROM_SOURCE` env var. Also, with the changes in this PR, the cmake build process handles the tasks of copying aotriton .so and images directory from `torch/lib` to the installation path. Pull Request resolved: pytorch#137443 Approved by: https://github.com/jithunnair-amd, https://github.com/jeffdaily Co-authored-by: Jithun Nair <jithun.nair@amd.com> (cherry picked from commit bc57635) Bump AOTriton to 0.8.2b (#1853) Fixes SWDEV-508774 (cherry picked from commit 4bed249) Enable head_dim == 512 with AOTriton 0.8.1 (cherry picked from commit 6edd36f) Add unit tests for head dimension 512 (cherry picked from commit 85290fa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SWDEV-508774