[release/2.4] [ROCm] fastSpecializedAtomicAdd for MI300 (#135770)#1677
Merged
pruthvistony merged 1 commit intoROCm:release/2.4from Nov 5, 2024
jerrymannil:release/2.4
Merged
[release/2.4] [ROCm] fastSpecializedAtomicAdd for MI300 (#135770)#1677pruthvistony merged 1 commit intoROCm:release/2.4from jerrymannil:release/2.4
pruthvistony merged 1 commit intoROCm:release/2.4from
jerrymannil:release/2.4
Conversation
MI300 adds HW support for packed bfloat16 and fp16. Enable via existing fastSpecializedAtomicAdd. Pull Request resolved: pytorch#135770 Approved by: https://github.com/xw285cornell, https://github.com/jianyuh
pruthvistony
approved these changes
Nov 5, 2024
jithunnair-amd
pushed a commit
that referenced
this pull request
Mar 17, 2025
MI300 adds HW support for packed bfloat16 and fp16. Enable via existing fastSpecializedAtomicAdd. Pull Request resolved: pytorch#135770 Approved by: https://github.com/xw285cornell, https://github.com/jianyuh Co-authored-by: Jeff Daily <jeff.daily@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MI300 adds HW support for packed bfloat16 and fp16. Enable via existing fastSpecializedAtomicAdd.
Helps with improving torch.scatter_add_ performance, among others.
Pull Request resolved: pytorch#135770
Approved by: https://github.com/xw285cornell, https://github.com/jianyuh