Skip to content

[release/2.3] cudagraph explicit sync only after capture_begin() (#1492)#1510

Merged
jithunnair-amd merged 1 commit intorelease/2.3from
dnikolaev/fix_cudagraph_explicit_sync_on_destroy_release2.3
Aug 1, 2024
Merged

[release/2.3] cudagraph explicit sync only after capture_begin() (#1492)#1510
jithunnair-amd merged 1 commit intorelease/2.3from
dnikolaev/fix_cudagraph_explicit_sync_on_destroy_release2.3

Conversation

@dnikolaev-amd
Copy link
Copy Markdown

Skip device sync in the ~CUDAGraph() destructor if capture_begin() method was not used and capture_dev_ variable is not initialized

  • cudagraph explicit sync only after capture_begin

  • use 'capture_dev_=-1' as not initialized value

  • use named constant instead of magic '-1' value

(cherry picked from release/2.2 commit eb433b9)

* cudagraph explicit sync only after capture_begin

* use 'capture_dev_=-1' as not initialized value

* use named constant instead of magic '-1' value

(cherry picked from commit eb433b9)
@jithunnair-amd jithunnair-amd merged commit 96dd291 into release/2.3 Aug 1, 2024
@jithunnair-amd jithunnair-amd deleted the dnikolaev/fix_cudagraph_explicit_sync_on_destroy_release2.3 branch August 1, 2024 16:16
dnikolaev-amd added a commit that referenced this pull request Aug 1, 2024
…) (#1510)

* cudagraph explicit sync only after capture_begin

* use 'capture_dev_=-1' as not initialized value

* use named constant instead of magic '-1' value

(cherry picked from commit eb433b9)
jithunnair-amd pushed a commit that referenced this pull request Oct 23, 2024
…) (#1510)

* cudagraph explicit sync only after capture_begin

* use 'capture_dev_=-1' as not initialized value

* use named constant instead of magic '-1' value

(cherry picked from commit eb433b9)
(cherry picked from commit 2827617)
jithunnair-amd pushed a commit that referenced this pull request Mar 17, 2025
…) (#1510)

* cudagraph explicit sync only after capture_begin

* use 'capture_dev_=-1' as not initialized value

* use named constant instead of magic '-1' value

(cherry picked from commit eb433b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants