[rocm6.3] Update triton requirements and conditionalize python_version < '3.13' only for PyTorch <= 2.5#68
Merged
jithunnair-amd merged 3 commits intorocm6.3from Feb 13, 2025
Merged
Conversation
manywheel/build_rocm.sh
Outdated
| if [[ $(uname) == "Linux" ]] && [[ "$DESIRED_PYTHON" != "3.12" || $(ver $PYTORCH_VERSION) -ge $(ver 2.4) ]]; then | ||
| # Triton commit got unified in PyTorch 2.5 | ||
| if [[ $(ver $PYTORCH_VERSION) -ge $(ver 2.5) ]]; then | ||
| if [[ $(ver $PYTORCH_VERSION) -ge $(ver 2.5) && $(ver "$DESIRED_PYTHON") -lt $(ver "3.13")]]; then |
Collaborator
There was a problem hiding this comment.
This is not where the condition needs to go. The py3.13 condition is basically to decide whether pytorch should have a python dependency on triton or not. For PyTorch2.5 and older, py3.13 was not supported for triton, so pytorch shouldn't have a py3.13 dependency on triton, but for PyTorch2.6 and newer, it can.
Collaborator
There was a problem hiding this comment.
This is the line that needs to conditionally add the and python_version < '3.13' part only for PyTorch2.5 and older: https://github.com/ROCm/builder/pull/68/files#diff-7096082d567b603ade9f800a8aad99eb4ec57ee15802d9dd4b4457f3a6609942R321
This was referenced Feb 13, 2025
jithunnair-amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Feb 13, 2025
Relates to: https://github.com/ROCm/rocAutomation/pull/660/files ROCm/builder#68 Validation: http://ml-ci-internal.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels/526/ --------- Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Feb 13, 2025
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Feb 13, 2025
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Feb 13, 2025
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Feb 13, 2025
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Feb 13, 2025
ethanwee1
added a commit
that referenced
this pull request
Feb 13, 2025
…n < '3.13' only for PyTorch <= 2.5 (#68) * conditionalize and python_version < '3.13'" only for PyTorch 2.5 and older * Limit TRITON_CONSTRAINT * Change triton wheel name to .git with 8 characters
jithunnair-amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Feb 15, 2025
Relates to: https://github.com/ROCm/rocAutomation/pull/660/files ROCm/builder#68 Validation: http://ml-ci-internal.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels/550/ --------- Co-authored-by: Jithun Nair <jithun.nair@amd.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
ethanwee1
added a commit
to ROCm/pytorch
that referenced
this pull request
Feb 17, 2025
Relates to: https://github.com/ROCm/rocAutomation/pull/660/files ROCm/builder#68 --------- Co-authored-by: Jithun Nair <jithun.nair@amd.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
jithunnair-amd
pushed a commit
that referenced
this pull request
Feb 17, 2025
…n < '3.13' only for PyTorch <= 2.5 (#68) AND add in conda to dockerfile for torchvision (#70) * Append torch commit to wheel name (#67) * Append torch commit if it is set * Remove git * Rename wheels * lint * refactor * [rocm6.3] Update triton requirements and conditionalize python_version < '3.13' only for PyTorch <= 2.5 (#68) * conditionalize and python_version < '3.13'" only for PyTorch 2.5 and older * Limit TRITON_CONSTRAINT * Change triton wheel name to .git with 8 characters * Create install_conda_docker.sh * Add conda in dockerfile
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conditionalize and python_version < '3.13'" only for PyTorch 2.5 and older
Tested via: http://ml-ci-internal.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels/541/