Skip to content

Replaced warpsize with C10_WARP_SIZE#249

Merged
amd-sriram merged 1 commit intomasterfrom
fix_group_batch_norm_warpsize
Jul 11, 2025
Merged

Replaced warpsize with C10_WARP_SIZE#249
amd-sriram merged 1 commit intomasterfrom
fix_group_batch_norm_warpsize

Conversation

@amd-sriram
Copy link
Copy Markdown
Collaborator

@amd-sriram amd-sriram commented Jul 11, 2025

Replaced warpsize with C10_WARP_SIZE

Tested with docker
registry-sc-harbor.amd.com/framework/compute-rocm-dkms-no-npi-hipclang:16387_ubuntu22.04_py3.10_pytorch_lw_rocm7.0_internal_testing_c3f758e0

Checked the UTs and these pass:

python apex/contrib/test/groupbn/test_groupbn.py
python apex/contrib/test/groupbn/test_groupbn_channel_last.py

Fixes: https://ontrack-internal.amd.com/browse/SWDEV-541770

Cherry-picked to release/1.4.0 branch via #250

Cherry-picked to release/1.5.0 branch via #251

Cherry-picked to release/1.6.0 branch via #252

Cherry-picked to release/1.7.0 branch via #253

@amd-sriram amd-sriram self-assigned this Jul 11, 2025
@amd-sriram amd-sriram marked this pull request as ready for review July 11, 2025 12:37
@amd-sriram amd-sriram merged commit 99c6242 into master Jul 11, 2025
@amd-sriram amd-sriram deleted the fix_group_batch_norm_warpsize branch July 11, 2025 12:39
@amd-sriram
Copy link
Copy Markdown
Collaborator Author

! cherry-pick --onto release/1.4.0 release/1.5.0 release/1.6.0 release/1.7.0

@okakarpa
Copy link
Copy Markdown
Collaborator

amd-sriram added a commit that referenced this pull request Jul 11, 2025
Co-authored-by: Sriram Kumar <skishore@amd.com>
amd-sriram added a commit that referenced this pull request Jul 11, 2025
Co-authored-by: Sriram Kumar <skishore@amd.com>
amd-sriram added a commit that referenced this pull request Jul 11, 2025
Co-authored-by: Sriram Kumar <skishore@amd.com>
amd-sriram added a commit that referenced this pull request Jul 11, 2025
Co-authored-by: Sriram Kumar <skishore@amd.com>
jithunnair-amd pushed a commit to ROCm/pytorch that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants