Conversation
This allows to build rccl-tests with message passing interface enabled, which was previously set to OFF via hard coding `USE_MPI`. As long as TheRock does not vendor MPI, this requires an MPI system installation, e.g. via vcpkg.
CMakeLists.txt
Outdated
| set(THEROCK_ARTIFACT_ARCHIVE_SUFFIX "" CACHE STRING "Suffix to add to artifact archive file stem names") | ||
|
|
||
| option(THEROCK_BUNDLE_SYSDEPS "Builds bundled system deps for portable builds into lib/rocm_sysdeps" ON) | ||
| option(THEROCK_ENABLE_MPI "Enables building components with message passing interface support" OFF) |
There was a problem hiding this comment.
Can you add a section to https://github.com/ROCm/TheRock/blob/main/docs/development/dependencies.md for MPI as well?
README.md
Outdated
| Further flags allow to build components with specific features enabled. | ||
|
|
||
| | Other flags | Description | | ||
| | --------------------------- | ------------------------------------------------------------------------ | | ||
| | `-DTHEROCK_ENABLE_MPI=OFF` | Enables building components with Message Passing Interface (MPI) support | |
There was a problem hiding this comment.
Oh I was thinking about just adding to https://github.com/ROCm/TheRock/blob/main/docs/development/dependencies.md for now. That's lower visibility than the root README.md which seems appropriate for now.
I guess it's fine to add to here too.
There was a problem hiding this comment.
That document rather has what TheRock ships as additional dependencies which it can bundle (or consume from the system) thus it didn't seemed appropriate for that particular option.
There was a problem hiding this comment.
I could see adding a new section for "currently unbundled deps" with MPI, then MPI could be moved from that section into the main section once we build/vendor it.
There was a problem hiding this comment.
Okay, let's follow up on this. Maybe want to add Fortran to this as well?
ScottTodd
left a comment
There was a problem hiding this comment.
LGTM ~ the open documentation comment threads (preferred as part of this PR but can be deferred to later)
Co-authored-by: Scott Todd <scott.todd0@gmail.com>
This allows to build rccl-tests with message passing interface enabled, which was previously set to OFF via hard coding
USE_MPI. As long as TheRock does not vendor MPI, this requires an MPI system installation, e.g. via vcpkg.