Conversation
Closes: #41 While this is a breaking change relative to 0.8.1, the new API introduced in 0.8.1 could not ever have been used meaningfully.
This fixes practical usability now that the Mutex actually works: When dealing with ValueInThread<&Mutex<T>>, that ValueInThread needs to be as easy to use as &Mutex<T> (which is always Copy+Clone).
a5e123e to
3814945
Compare
bors Bot
added a commit
to RIOT-OS/RIOT
that referenced
this pull request
Feb 20, 2023
19288: rust: Update riot-sys and riot-wrappers r=kaspar030 a=chrysn ### Contribution description rust: Update riot-sys and riot-wrappers * riot-wrappers: * Fix infinite loop when using a Mutex * Make ValueInThread Copy/Clone * riot-sys: * Export xxx_DEV (eg. I2C_DEV) C macros as functions * Add auto_init_utils.h ### Testing procedure CI checks should suffice. ### Issues/PRs references This pulls in fixes from * RIOT-OS/rust-riot-sys#18 * RIOT-OS/rust-riot-sys#17 / RIOT-OS/rust-riot-wrappers#37 * RIOT-OS/rust-riot-wrappers#42 / RIOT-OS/rust-riot-wrappers#41 Co-authored-by: chrysn <chrysn@fsfe.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily fixes #41, and adds infrastructure to also run (not only build) tests, as well as a test that'd have caught this.