Skip to content

tests: gnrc_ipv6_ext: replace default netif with dummy#9654

Merged
cladmi merged 1 commit intoRIOT-OS:masterfrom
miri64:tests/fix/gnrc_ipv6_ext-dummy-iface
Aug 1, 2018
Merged

tests: gnrc_ipv6_ext: replace default netif with dummy#9654
cladmi merged 1 commit intoRIOT-OS:masterfrom
miri64:tests/fix/gnrc_ipv6_ext-dummy-iface

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Jul 31, 2018

Contribution description

Use a minimalistic dummy instead of the default interface for testing
the gnrc_ipv6_ext module

Currently the default interface is used which leads to problems with
this test, since random traffic on the medium or a missing default
interface might lead to failed results.

Issues/PRs references

Similar issue as with #9648

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: tests Area: tests and testing framework GNRC labels Jul 31, 2018
@miri64 miri64 added this to the Release 2018.07 milestone Jul 31, 2018
miri64
miri64 commented Jul 31, 2018
View reviewed changes
tests/gnrc_ipv6_ext/Makefile Outdated
nucleo-f303k8 nucleo-f334r8 nucleo-l053r8 \
spark-core stm32f0discovery telosb \
wsn430-v1_3b wsn430-v1_4 yunjia-nrf51822 z1
BOARD_INSUFFICIENT_MEMORY :=
Copy link
Copy Markdown
Member Author

@miri64 miri64 Jul 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will run build test locally and refill this list according to the results

@miri64 miri64 requested a review from cladmi July 31, 2018 16:15
@cladmi cladmi added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 31, 2018
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Jul 31, 2018

It does not crash anymore on arduino-zero and stm32f4discovery and test work with both debug and without.

Also still works for iotlab-m3, samr21-xpro and native.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Jul 31, 2018

I let you update the BOARDS_INSUFFICIENT_MEMORY and murdock verify.

@cladmi cladmi added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 31, 2018
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jul 31, 2018

Since the tap dependency is removed for native, I add this test for testing.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 31, 2018
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Jul 31, 2018

You can squash and merge when murdock is running and happy.

@cladmi cladmi added Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Aug 1, 2018
@miri64 miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 1, 2018
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Aug 1, 2018

@miri64 Murdock compile tests pass, please squash. It will re-run with "CI:run test" after.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 1, 2018
@miri64
tests: gnrc_ipv6_ext: replace default netif with dummy
c4ba2b5 
Use a minimalistic dummy instead of the default interface for testing
the `gnrc_ipv6_ext` module.

Currently the default interface is used which leads to problems with
this test, since random traffic on the medium or a missing default
interface might lead to failed results.

Since the `tap` dependency is removed for `native`, I add this test for
testing on CI.
@miri64 miri64 force-pushed the tests/fix/gnrc_ipv6_ext-dummy-iface branch from afa9706 to c4ba2b5 Compare August 1, 2018 15:26
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 1, 2018

Rebased and squashed

@miri64 miri64 mentioned this pull request Aug 1, 2018
Merged
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 1, 2018
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 1, 2018

Still hanging :-/

@miri64 miri64 removed the CI: run tests If set, CI server will run tests on hardware for the labeled PR label Aug 1, 2018
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 1, 2018
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Aug 1, 2018 •
edited
Loading

Tests work with and without the debug enabled in gnrc_ipv6.c for native samr21-xpro, iotlab-m3 and arduino-zero.

Currently in murdock the test would only checks for pkt->users: 0 as debug is not enabled anyway.

@cladmi cladmi merged commit 2ce25d4 into RIOT-OS:master Aug 1, 2018
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Aug 1, 2018

Please backport.

@miri64 miri64 deleted the tests/fix/gnrc_ipv6_ext-dummy-iface branch August 1, 2018 18:10
@miri64 miri64 mentioned this pull request Aug 1, 2018
Merged
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 1, 2018

Backport provided in #9671.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cladmi cladmi cladmi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: network Area: Networking Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2018.07

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @cladmi