Skip to content

drivers/jc42: adapt to new i2c API#9492

Merged
smlng merged 1 commit intoRIOT-OS:new_i2c_iffrom
MichelRottleuthner:pr_jc42_new_i2c
Jul 5, 2018
Merged

drivers/jc42: adapt to new i2c API#9492
smlng merged 1 commit intoRIOT-OS:new_i2c_iffrom
MichelRottleuthner:pr_jc42_new_i2c

Conversation

@MichelRottleuthner
Copy link
Copy Markdown
Contributor

Contribution description

This adapts the jc42 driver to the new i2c api. I don't have hardware to test.

Issues/PRs references

#6577

@MichelRottleuthner MichelRottleuthner added Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force labels Jul 4, 2018
@aabadie aabadie requested a review from bergzand July 4, 2018 08:16
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jul 4, 2018

I think @bergzand might be able to test, since he initially contributed this driver.

@bergzand
Copy link
Copy Markdown
Member

bergzand commented Jul 4, 2018

I don't mind testing this, but I have to check if I currently have access to the hardware.

Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested ACK, good changes look good.

@smlng
Copy link
Copy Markdown
Member

smlng commented Jul 5, 2018

please rebase onto new_i2c_if branch to get rid of the pn532 error

@MichelRottleuthner
Copy link
Copy Markdown
Contributor Author

rebased

@smlng smlng merged commit a0f30e1 into RIOT-OS:new_i2c_if Jul 5, 2018
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
dylad pushed a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
dylad pushed a commit that referenced this pull request Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants