Skip to content

cpu/nrf51: adapt to new I2C api#9477

Merged
dylad merged 5 commits intoRIOT-OS:new_i2c_iffrom
aabadie:new_i2c_if_nrf51
Jul 3, 2018
Merged

cpu/nrf51: adapt to new I2C api#9477
dylad merged 5 commits intoRIOT-OS:new_i2c_iffrom
aabadie:new_i2c_if_nrf51

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jul 2, 2018

Contribution description

This PR provides the adaption of nrf51 cpus to the new I2C api. The microbit board peripheral configuration was also adapted.

A fix for the on-board accelerometer driver defines is also provided here. I tested this PR with success with tests/drivers_mma8x5x application.

Issues/PRs references

#6577

@aabadie aabadie added Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force Area: cpu Area: CPU/MCU ports labels Jul 2, 2018
@aabadie aabadie requested review from dylad and haukepetersen July 2, 2018 15:10
Copy link
Copy Markdown
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @aabadie for handling this !!
Looks like the TWI driver for NRF51 is as tricky as NRF52 one...
This looks good, but I don't have any hardware to test.

Copy link
Copy Markdown
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK!

@dylad
Copy link
Copy Markdown
Member

dylad commented Jul 3, 2018

Let's merge this !
Ignore Travis for now as cppcheck is too old.

@dylad dylad merged commit 1951e04 into RIOT-OS:new_i2c_if Jul 3, 2018
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
dylad added a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
dylad added a commit that referenced this pull request Jul 11, 2018
cpu/nrf51: adapt to new I2C api
@aabadie aabadie added this to the Release 2018.10 milestone Nov 5, 2018
@aabadie aabadie deleted the new_i2c_if_nrf51 branch January 15, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants