sys: Add generic pipe#935
Conversation
|
I would suggest, that the changes to the ringbuffer go in its own PR. And doxygen information is missing, have a look at https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions#documentation |
|
@haukepetersen please see #933. |
|
seen and commented on :-) |
|
@Kijewski please rebase |
|
It doesn't make sense to rebase this before #1101 is merged. |
|
Rebased since it is a "FIX ME FIRST" PR. Still depends on #1101. |
There was a problem hiding this comment.
the include block should be positioned after the doxygen header
|
I give an ACK when comments are addressed. |
|
Rebased and comments addressed. Please ACK #1101 first. :) |
sys/include/pipe.h
Outdated
There was a problem hiding this comment.
these 2 lines do following RIOTs coding conventions also after the doxygen block :-)
|
ACK when you change this minor little style thingy... |
|
Do you mean changing this way: https://github.com/Kijewski/RIOT/commit/e4652e7a02ae10ebdf909b6a4865f4e9fe0bd020? |
|
check :-) |
This PR adds a generic pipe. You can write to it and read from it.
If the pipe is empty and one reads from it, then the threads gets laid to sleep. Same for writing.
The implementation takes care of interrupts, and won't send the current thread sleeping in an ISR.
[edit] This PR is (re)based on
#933#1101. [/edit]