drivers/mpu9150: adapt to new I2C api#9277
Merged
aabadie merged 1 commit intoRIOT-OS:new_i2c_iffrom Jul 1, 2018
Merged
Conversation
47 tasks
199e5e1 to
4496b65
Compare
4496b65 to
8364976
Compare
smlng
suggested changes
Jun 29, 2018
Member
smlng
left a comment
There was a problem hiding this comment.
otherwise looks good, tested on pba-d-01-kw2x with drivers test app.
|
|
||
| /* Configure Power Down mode */ | ||
| i2c_write_reg(DEV_I2C, DEV_COMP_ADDR, COMPASS_CNTL_REG, MPU9150_COMP_POWER_DOWN); | ||
| i2c_write_reg(DEV_I2C, DEV_COMP_ADDR, COMPASS_CNTL_REG, MPU9150_COMP_POWER_DOWN, 0); |
Member
There was a problem hiding this comment.
you miss the i2c_read_reg call 7 lines above
8364976 to
e38d743
Compare
smlng
approved these changes
Jun 29, 2018
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/mpu9150: adapt to new I2C api
dylad
pushed a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/mpu9150: adapt to new I2C api
dylad
pushed a commit
that referenced
this pull request
Jul 11, 2018
drivers/mpu9150: adapt to new I2C api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Adapt mpu9150 driver to new I2C api
Issues/PRs references
#6577