drivers: si70xx: adapt to new I2C api.#9205
Merged
dylad merged 1 commit intoRIOT-OS:new_i2c_iffrom Jun 18, 2018
Merged
Conversation
47 tasks
dylad
reviewed
Jun 7, 2018
Member
dylad
left a comment
There was a problem hiding this comment.
Tested your PR (with the I2C_ACK replaced by 0) and works well on my custom board (SAML21) with the current driver I have.
|
|
||
| i2c_acquire(SI70XX_I2C); | ||
|
|
||
| if (i2c_write_byte(SI70XX_I2C, SI70XX_ADDR, command) != 1) { |
Member
There was a problem hiding this comment.
I2C_ACK doesn't exist anymore as we switch to errno used. This must be replaced by 0.
8949e4e to
6a1d9b7
Compare
Member
Author
|
Rebased and adapted. |
dylad
approved these changes
Jun 18, 2018
Member
dylad
left a comment
There was a problem hiding this comment.
Tested work on custom hardware (based on SAML21 cpu)
ACK !
please squash
6a1d9b7 to
a8bcc10
Compare
Member
Author
|
Squashed. |
Member
|
Thanks for your work @basilfx ! Here we go ! |
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
drivers: si70xx: adapt to new I2C api.
dylad
added a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
drivers: si70xx: adapt to new I2C api.
dylad
added a commit
that referenced
this pull request
Jul 11, 2018
drivers: si70xx: adapt to new I2C api.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR updates the Si70xx drivers. Tested this one on the SLTB001A (EFM32, adapted).
Issues/PRs references
#6577