IIRC we don't revert commits (on my first PRs I did things like that, and @miri64 told me that), but rather make "normal" commits which revert what have you done.

@kYc0o I think you must have misinterpreted the situation where you got that advice. There is no difference between a revert and a commit undoing the same change. On the other hand, if you need to revert only part of a commit, you will need to manually create a commit to perform that change.

@kYc0o I think you must have misinterpreted the situation where you got that advice. There is no difference between a revert and a commit undoing the same change. On the other hand, if you need to revert only part of a commit, you will need to manually create a commit to perform that change.

I certainly missed the point, you're right.

I can ACK this too, since I was the one who ACKed the original change.

Just wanted to confirm, that @kYc0o might have misunderstood me, because I don't remember saying something like that and would really be surprised about it ^^.

I think the situation was different and a revert would make the things worse at that time, so I was told to not do revert but better a new commit undoing the changes. I think it was even not all of the changes but just one. Anyways, that's back on the time where I was doing my first serious C code ^^'.

Sorry for the noise.

Maybe it was that we don't click the revert button of a PR after it has been merged, but create a new PR (which might contain revert comits)?

Maybe it was that we don't click the revert button of a PR after it has been merged, but create a new PR (which might contain revert comits)?

Bingo! I think that was the advice I was given. Thanks for the reminder @kaspar030 !