drivers/mag3110: apply unified params definition scheme#8758
Merged
aabadie merged 3 commits intoRIOT-OS:new_i2c_iffrom Jul 4, 2018
Merged
drivers/mag3110: apply unified params definition scheme#8758aabadie merged 3 commits intoRIOT-OS:new_i2c_iffrom
aabadie merged 3 commits intoRIOT-OS:new_i2c_iffrom
Conversation
47 tasks
0582e86 to
6264419
Compare
Member
|
@aabadie please rebase and do you want to add I2C API adaption, too? This one is missing for the I2C rework but this PR is referenced anyway. However, then please rebase onto |
6264419 to
45a8a83
Compare
Contributor
Author
|
The work was already done, but I forgot to push it and to change the base branch... |
45a8a83 to
a73efed
Compare
smlng
approved these changes
Jul 4, 2018
Member
smlng
left a comment
There was a problem hiding this comment.
tested ACK, used pba-d-01-kw2x with onboard sensor
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/mag3110: apply unified params definition scheme
dylad
pushed a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/mag3110: apply unified params definition scheme
dylad
pushed a commit
that referenced
this pull request
Jul 11, 2018
drivers/mag3110: apply unified params definition scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR update the params definitions scheme for this device driver.
Also forgot this one last week.
Issues/PRs references
Initially done in #7937 and related to #7519
#6577