drivers/lsm303dlhc: apply unified driver params scheme + cleanup#8699
Merged
dylad merged 4 commits intoRIOT-OS:new_i2c_iffrom Jul 9, 2018
Merged
drivers/lsm303dlhc: apply unified driver params scheme + cleanup#8699dylad merged 4 commits intoRIOT-OS:new_i2c_iffrom
dylad merged 4 commits intoRIOT-OS:new_i2c_iffrom
Conversation
Contributor
Author
|
Just tested on iotlab-m3 (not on iotlab), works |
kYc0o
approved these changes
May 23, 2018
Contributor
kYc0o
left a comment
There was a problem hiding this comment.
ACK. I think it would be better to squash everything in a commit, since the API change commit it's enough to break quite some stuff.
47 tasks
664d8b3 to
6de7017
Compare
fd93641 to
e75c837
Compare
e75c837 to
69ba59b
Compare
Member
|
Can someone test it on a second CPU arch so we can push the big green button ? |
Member
|
Here we go ! |
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
…dlhc drivers/lsm303dlhc: apply unified driver params scheme + cleanup
dylad
added a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
…dlhc drivers/lsm303dlhc: apply unified driver params scheme + cleanup
dylad
added a commit
that referenced
this pull request
Jul 11, 2018
drivers/lsm303dlhc: apply unified driver params scheme + cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR updates the params definitions scheme and makes some cleanup in the internal driver implementation.
Issues/PRs references
Initially done in #7937 and related to #7519
#6577