drivers/l3g4200d: apply unified driver params scheme + cleanup#8698
Merged
aabadie merged 4 commits intoRIOT-OS:new_i2c_iffrom Jul 4, 2018
Merged
drivers/l3g4200d: apply unified driver params scheme + cleanup#8698aabadie merged 4 commits intoRIOT-OS:new_i2c_iffrom
aabadie merged 4 commits intoRIOT-OS:new_i2c_iffrom
Conversation
ee4d3ac to
44f8883
Compare
Contributor
Author
|
Just tested on iotlab-m3, works. But I realized that int1 and int2 pins are not used in the code. So the refactoring could go further by simply removing them. |
47 tasks
44f8883 to
5e9cfc7
Compare
5e9cfc7 to
94a51c2
Compare
94a51c2 to
7f73561
Compare
smlng
approved these changes
Jul 4, 2018
Member
smlng
left a comment
There was a problem hiding this comment.
untested ACK; API changes are fine. However, for future reference it might be better to stick to API adaptions and have the param scheme stuff in a followup PR.
Contributor
Author
The problem is that this PR was opened long time ago. I just rebased it on new_i2c_if and applied the I2C rework there for simplicity. |
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/l3g4200d: apply unified driver params scheme + cleanup
dylad
pushed a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/l3g4200d: apply unified driver params scheme + cleanup
dylad
pushed a commit
that referenced
this pull request
Jul 11, 2018
drivers/l3g4200d: apply unified driver params scheme + cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR updates the params definitions scheme and makes some cleanup in the driver implementation.
Issues/PRs references
Initially done in #7937 and related to #7519
#6577