Skip to content

drivers/tsl2561: apply unified params definition scheme + cleanup#8673

Merged
aabadie merged 6 commits intoRIOT-OS:new_i2c_iffrom
aabadie:pr/drivers/params/tsl2561
Jul 3, 2018
Merged

drivers/tsl2561: apply unified params definition scheme + cleanup#8673
aabadie merged 6 commits intoRIOT-OS:new_i2c_iffrom
aabadie:pr/drivers/params/tsl2561

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Feb 28, 2018 •
edited
Loading

Contribution description

This PR update the params definitions scheme for the tsl2561 device driver.

Issues/PRs references

Initially done in #7937 and related to #7519

#6577

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 28, 2018
@aabadie aabadie changed the title drivers/tsl2561: apply unified params definition scheme drivers/tsl2561: apply unified params definition scheme + cleanup Feb 28, 2018
@aabadie aabadie mentioned this pull request May 23, 2018
Closed
@haukepetersen haukepetersen mentioned this pull request May 25, 2018
Closed
47 tasks
@aabadie aabadie changed the base branch from master to new_i2c_if May 27, 2018 21:16
@aabadie aabadie added TF: I2C Marks issues and PRs related to the work of the I²C rework task force and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 27, 2018
@aabadie aabadie force-pushed the pr/drivers/params/tsl2561 branch from ead0c01 to b4e24c4 Compare May 27, 2018 21:20
@aabadie aabadie force-pushed the pr/drivers/params/tsl2561 branch from b4e24c4 to 33d4182 Compare June 8, 2018 07:54
@aabadie aabadie force-pushed the pr/drivers/params/tsl2561 branch from 33d4182 to 12460d4 Compare June 18, 2018 11:34
smlng
smlng reviewed Jun 28, 2018
View reviewed changes
sys/auto_init/saul/auto_init_tsl2561.c Outdated
* @brief Define the number of configured sensors
*/
#define TSL2561_NUMOF (sizeof(tsl2561_params) / sizeof(tsl2561_params[0]))
#define TSL2561_NUM (sizeof(tsl2561_params) / sizeof(tsl2561_params[0]))
Copy link
Copy Markdown
Member

@smlng smlng Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this renaming? Its I2C_NUMOF, too?

Copy link
Copy Markdown
Contributor Author

@aabadie aabadie Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@aabadie aabadie force-pushed the pr/drivers/params/tsl2561 branch from 12460d4 to a751807 Compare June 29, 2018 13:46
@MichelRottleuthner
Copy link
Copy Markdown
Contributor

MichelRottleuthner commented Jul 3, 2018

tested on pba-d-01-kw2x, works!

@smlng
Copy link
Copy Markdown
Member

smlng commented Jul 3, 2018

@MichelRottleuthner care to approve and merge then?

MichelRottleuthner
MichelRottleuthner approved these changes Jul 3, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichelRottleuthner MichelRottleuthner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@MichelRottleuthner
Copy link
Copy Markdown
Contributor

MichelRottleuthner commented Jul 3, 2018

@aabadie do you want to squash the param/i2c changes into separate commits?

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jul 3, 2018

@MichelRottleuthner, for me the history of commits is ok in this PR. It can be merged as is.

@aabadie aabadie merged commit 9b4705f into RIOT-OS:new_i2c_if Jul 3, 2018
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
@aabadie @basilfx
Merge pull request RIOT-OS#8673 from aabadie/pr/drivers/params/tsl2561
036e551 
drivers/tsl2561: apply unified params definition scheme + cleanup
dylad pushed a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
@aabadie @dylad
Merge pull request RIOT-OS#8673 from aabadie/pr/drivers/params/tsl2561
b1aba42 
drivers/tsl2561: apply unified params definition scheme + cleanup
dylad pushed a commit that referenced this pull request Jul 11, 2018
@aabadie @dylad
Merge pull request #8673 from aabadie/pr/drivers/params/tsl2561
992da8d 
drivers/tsl2561: apply unified params definition scheme + cleanup
@aabadie aabadie deleted the pr/drivers/params/tsl2561 branch September 23, 2018 08:47
@aabadie aabadie added this to the Release 2018.10 milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichelRottleuthner MichelRottleuthner MichelRottleuthner approved these changes

+1 more reviewer

@smlng smlng smlng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kYc0o kYc0o

Labels

Area: drivers Area: Device drivers Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. TF: I2C Marks issues and PRs related to the work of the I²C rework task force Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.10

Development

Successfully merging this pull request may close these issues.

4 participants

@aabadie @MichelRottleuthner @smlng @kYc0o