Skip to content

make: add flag for no-implicit-fallthrough in CXXFLAGS#8617

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
jia200x:pr/cxxflags
Feb 23, 2018
Merged

make: add flag for no-implicit-fallthrough in CXXFLAGS#8617
aabadie merged 1 commit intoRIOT-OS:masterfrom
jia200x:pr/cxxflags

Conversation

@jia200x
Copy link
Copy Markdown
Member

@jia200x jia200x commented Feb 22, 2018

Contribution description

This PR adds -Wno-implicit-fallthrough to CXXFLAGS, with the same purposes as #8603

Issues/PRs references

#8603, #8616

@aabadie aabadie added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 22, 2018
jnohlgard
jnohlgard approved these changes Feb 23, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Feb 23, 2018

Murdock error is unrelated..

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Feb 23, 2018 

--- build output of app tests/conn_can for board waspmote-pro (raw, runtime=1.1s):
-- running on worker haw-icc thread 4, build number 216.
make: Entering directory '/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/tests/conn_can'
Building application "tests_conn_can" for "waspmote-pro" with MCU "atmega1281".

device.c: In function 'can_device_calc_bittiming':
device.c:564:24: error: 'tseg2' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     timing->phase_seg2 = tseg2;
                        ^
device.c:580:68: error: 'tseg1' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     timing->bitrate = clock / (timing->brp * (CAN_SYNC_SEG + tseg1 + tseg2));
                                                                    ^
device.c: At top level:
cc1: error: unrecognized command line option '-Wno-implicit-fallthrough' [-Werror]
cc1: all warnings being treated as errors
/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/Makefile.base:81: recipe for target '/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/build/can/device.o' failed
make[3]: *** [/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/build/can/device.o] Error 1
/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/Makefile.base:20: recipe for target 'ALL--/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/sys/can' failed
make[2]: *** [ALL--/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/sys/can] Error 2
/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/Makefile.base:20: recipe for target 'ALL--/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/sys' failed
make[1]: *** [ALL--/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/sys] Error 2
/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/tests/conn_can/../../Makefile.include:324: recipe for target 'link' failed
make: *** [link] Error 2
make: Leaving directory '/tmp/dwq.0.0677888750370953/4a3d2e5e8b5b332254f74cfdca0d1d2d/tests/conn_can'
-- build directory size: 864K

@jnohlgard jnohlgard added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 23, 2018
@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Feb 23, 2018

The sys/can error has been fixed in master, retrying Murdock

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Feb 23, 2018

All green, let's go

@aabadie aabadie merged commit 2d6f34d into RIOT-OS:master Feb 23, 2018
@jnohlgard jnohlgard mentioned this pull request Jun 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

Assignees

No one assigned

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jia200x @jnohlgard @aabadie