Skip to content

pkg/openthread: cleanup makefile + fix implicit-fallthrough warning#8616

Merged
jia200x merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/fix_openthread_build
Feb 22, 2018
Merged

pkg/openthread: cleanup makefile + fix implicit-fallthrough warning#8616
jia200x merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/fix_openthread_build

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Feb 22, 2018

Contribution description

This PR fixes the openthread build failure because of an implicit-fallthrough warning.

Murdock is complaining about it in #8604 and maybe in other places.

Issues/PRs references

#8604

@aabadie aabadie added Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: CI Area: Continuous Integration of RIOT components labels Feb 22, 2018
@aabadie aabadie changed the title pkg/openthread: cleanup + fix implicit-fallthrough warning pkg/openthread: cleanup makefile + fix implicit-fallthrough warning Feb 22, 2018
@jnohlgard jnohlgard mentioned this pull request Feb 22, 2018
13 tasks
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Feb 22, 2018

Can we merge this one asap ? Otherwise the openthread build failure is blocking all ready to be merged PRs.

@jnohlgard
Copy link
Copy Markdown
Member

This should already be addressed on a global level by #8603

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Feb 22, 2018

This should already be addressed on a global level by #8603

Indeed but apparently this doesn't apply to openthread. Looking at failed jobs, they all happen on mobi1.inet.haw-hamburg.de. Are the toolchains installed on workers all in sync ?

@smlng
Copy link
Copy Markdown
Member

smlng commented Feb 22, 2018

Are the toolchains installed on workers all in sync

Nope they differ, some workers did a restart and were updated (like mobi1, e5). Also, is OpenThread C++, then #8603 doesn't help by setting CFLAGS only.

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 22, 2018
@jia200x
Copy link
Copy Markdown
Member

jia200x commented Feb 22, 2018

Nope they differ, some workers did a restart and were updated (like mobi1, e5). Also, is OpenThread C++, then #8603 doesn't help by setting CFLAGS only.

Maybe we could do the same with the CXXFLAGS, that's what the current OT package is doing through OPENTHREAD_COMMON_FLAGS :)

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Feb 22, 2018 via email

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Feb 22, 2018

Maybe we could do the same with the CXXFLAGS, that's what the current OT package is doing through OPENTHREAD_COMMON_FLAGS

This is basically what this change does.

@jia200x
Copy link
Copy Markdown
Member

jia200x commented Feb 22, 2018

This is basically what this change does.

I was refering to something similar to #8603.
In any case, I would go for merging this one and then improve the OT Makefile (maybe we could just use the same CFLAGS and CXXFLAGS settings of RIOT)

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Feb 22, 2018

I was refering to something similar to #8603.

Yes, sorry I misunderstood you initial comment.

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Feb 22, 2018

In any case, I would go for merging this one and then improve the OT Makefile

Then could someone ACK and merge ?

they differ, some workers did a restart and were updated (like mobi1, e5)

So this means that workers are not all using the same version of the toolchain ? This doesn't sounds like a good thing to me. Do we have a roadmap/instructions for updating the CI workers ?

@jia200x
Copy link
Copy Markdown
Member

jia200x commented Feb 22, 2018

ACK on my side.

I will open a PR forRIOT/#issuecomment-367672886 and then improve th OT Makefile when I find some time

@jia200x
Copy link
Copy Markdown
Member

jia200x commented Feb 22, 2018

& GO

@jia200x jia200x merged commit 520852f into RIOT-OS:master Feb 22, 2018
@aabadie aabadie deleted the pr/fix_openthread_build branch February 26, 2018 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants