pkg/openthread: cleanup makefile + fix implicit-fallthrough warning#8616
pkg/openthread: cleanup makefile + fix implicit-fallthrough warning#8616jia200x merged 1 commit intoRIOT-OS:masterfrom
Conversation
|
Can we merge this one asap ? Otherwise the openthread build failure is blocking all ready to be merged PRs. |
|
This should already be addressed on a global level by #8603 |
Indeed but apparently this doesn't apply to openthread. Looking at failed jobs, they all happen on mobi1.inet.haw-hamburg.de. Are the toolchains installed on workers all in sync ? |
Nope they differ, some workers did a restart and were updated (like mobi1, e5). Also, is OpenThread C++, then #8603 doesn't help by setting CFLAGS only. |
Maybe we could do the same with the CXXFLAGS, that's what the current OT package is doing through OPENTHREAD_COMMON_FLAGS :) |
|
On Feb 22, 2018 13:58, "jia200x" <notifications@github.com> wrote:
Nope they differ, some workers did a restart and were updated (like mobi1,
e5). Also, is OpenThread C++, then #8603
<#8603> doesn't help by setting CFLAGS
only.
Maybe we could do the same with the CXXFLAGS, that's what the current OT
package is doing through OPENTHREAD_COMMON_FLAGS :)
Yes, let's do that
|
This is basically what this change does. |
I was refering to something similar to #8603. |
Yes, sorry I misunderstood you initial comment. |
Then could someone ACK and merge ?
So this means that workers are not all using the same version of the toolchain ? This doesn't sounds like a good thing to me. Do we have a roadmap/instructions for updating the CI workers ? |
|
ACK on my side. I will open a PR forRIOT/#issuecomment-367672886 and then improve th OT Makefile when I find some time |
|
& GO |
Contribution description
This PR fixes the openthread build failure because of an implicit-fallthrough warning.
Murdock is complaining about it in #8604 and maybe in other places.
Issues/PRs references
#8604