Skip to content

drivers/sx127x: Fix -Wmaybe-uninitialized warning#8604

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/sx127x-uninitialized
Feb 22, 2018
Merged

drivers/sx127x: Fix -Wmaybe-uninitialized warning#8604
aabadie merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/sx127x-uninitialized

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard commented Feb 20, 2018

Contribution description

Fix a warning in the get_state function in sx127x

Issues/PRs references

#8265

@jnohlgard jnohlgard added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 20, 2018
@jnohlgard jnohlgard added this to the Release 2018.04 milestone Feb 20, 2018
@jnohlgard jnohlgard requested a review from aabadie February 20, 2018 16:03
@jnohlgard jnohlgard mentioned this pull request Feb 20, 2018
Closed
13 tasks
aabadie
aabadie reviewed Feb 20, 2018
View reviewed changes
drivers/sx127x/sx127x_netdev.c Outdated

default:
/* prevent "‘state’ may be used uninitialized in this function" */
state = NETOPT_STATE_OFF;
Copy link
Copy Markdown
Contributor

@aabadie aabadie Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just initialize the variable with this value line 542 ?

Copy link
Copy Markdown
Member Author

@jnohlgard jnohlgard Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Will fix

Copy link
Copy Markdown
Member Author

@jnohlgard jnohlgard Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amended

@jnohlgard jnohlgard force-pushed the pr/sx127x-uninitialized branch from 7495554 to 73c85cc Compare February 22, 2018 07:44
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 22, 2018
@aabadie aabadie mentioned this pull request Feb 22, 2018
Merged
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Feb 22, 2018

@gebart see #8616 for the failures reported by Murdock.

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 22, 2018
aabadie
aabadie approved these changes Feb 22, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK and go

@aabadie aabadie merged commit 1f49c0d into RIOT-OS:master Feb 22, 2018
@jnohlgard jnohlgard deleted the pr/sx127x-uninitialized branch September 24, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie approved these changes

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.04

Development

Successfully merging this pull request may close these issues.

2 participants

@jnohlgard @aabadie