Conversation
| $(error This package can only be used with EFM32 CPUs) | ||
| endif | ||
|
|
||
| CFLAGS += -Wno-error=implicit-fallthrough |
There was a problem hiding this comment.
minor nit: we typically use a different notation: -Wno-implicit-fallthrough
There was a problem hiding this comment.
minor nit: we typically use a different notation:
-Wno-implicit-fallthrough
I would prefer if the error is disabled rather than hiding the warning entirely.
Edit: added reference to what this was meant as a reply to.
There was a problem hiding this comment.
good point, make sense to retain the warning
There was a problem hiding this comment.
This is even more important in this package, as the upstream software is mostly used in RIOT. So if we hide the warning in RIOT, this will never be fixed upstream.
There was a problem hiding this comment.
on the other hand: murdock doesn't like it, at least there is an error.
There was a problem hiding this comment.
well we do have a range of different, platform dependent compilers of various version - hence we need a solution that works for a considerable number of them. That means, GCC 5, 6, and 7 for instance; and without much if-else stuff.
I agree it would be best to have the warnings but if that doesn't work we should fall-back to use -Wno-implicit-fallthrough as we do for in (many) other cases.
|
@basilfx you might be interested as you maintain the package repository. |
|
@pyropeter can you address Murdock errors and rebase? |
Ok I just read that's because Murdock's GCC is old. So I think to patch it upstream it's a better idea. |
|
Closing this issue in favor of #8554 (merged). |
Contribution description
Fix fallthrough errors for GCC 7.x (#8265).
Issues/PRs references
Fixes #8266