examples/gnrc_tftp: fix implicit fallthrough error#8382
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Jan 22, 2018
Merged
examples/gnrc_tftp: fix implicit fallthrough error#8382kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
Conversation
jnohlgard
approved these changes
Jan 18, 2018
Member
jnohlgard
left a comment
There was a problem hiding this comment.
ACK.
Does the end of the default case need a comment as well (or break) or is that not covered by the gcc warnings?
a9c3cd0 to
8f659ef
Compare
Member
Author
it actually does not, but its advised (good practice) to add a break nevertheless, to avoid ugly bugs if someone adds a case after default in the future. Hence, I added a break. |
Member
|
Needs backport. |
13 tasks
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 28, 2018
Without this fix the listener doesn't actually listen on the (potentially) ephemeral port introduced in RIOT-OS#8382, but on port 0 which is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
fixes comment for intentional fall through to prevent compile error with GCC 7.x.
Also fixes return code in case of error.
Issues/PRs references
#8265