First apply board includes, then det. CC caps#722
Merged
OlegHahm merged 1 commit intoRIOT-OS:masterfrom Feb 18, 2014
Kijewski:fixup-664
Merged
First apply board includes, then det. CC caps#722OlegHahm merged 1 commit intoRIOT-OS:masterfrom Kijewski:fixup-664
OlegHahm merged 1 commit intoRIOT-OS:masterfrom
Kijewski:fixup-664
Conversation
In #664 I added a test that determines if the supplied compiler understands the `-fno-delete-null-pointer-checks` flag. The problem is that the `$(CC)` supplied on command line or in the application's Makefile is used, but not the one the `$(BOARD)`'s Makefile sets. That problem was overlooked as all the boards use GCC, and GCC happens to know the flag. But if some future board does not use GCC, then the wrong order of the checks could pose a problem.
Member
|
Sounds sensible. |
Contributor
Author
|
ACK anyone? It's a trivial change. :) |
Member
|
ACK and go. |
OlegHahm
added a commit
that referenced
this pull request
Feb 18, 2014
First apply board includes, then det. CC caps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #664 I added a test that determines if the supplied compiler
understands the
-fno-delete-null-pointer-checksflag. The problem isthat the
$(CC)supplied on command line or in the application'sMakefile is used, but not the one the
$(BOARD)'s Makefile sets.That problem was overlooked as all the boards use GCC, and GCC happens
to know the flag. But if some future board does not use GCC, then the
wrong order of the checks could pose a problem.