kinetis: Use 9 bit UART config for 8E1, 8O1 modes#7165
kinetis: Use 9 bit UART config for 8E1, 8O1 modes#7165jnohlgard merged 1 commit intoRIOT-OS:masterfrom
Conversation
| .dev = UART0, | ||
| .clken = (volatile uint32_t*)(BITBAND_REGADDR(SIM->SCGC4, SIM_SCGC4_UART0_SHIFT)), | ||
| .freq = CLOCK_CORECLOCK, | ||
| .pin_rx = GPIO_PIN(PORT_D, 6), |
There was a problem hiding this comment.
I don't have this board so I can't test this, could you open a separate PR for this, please?
|
The configuration change looks correct, but I did not test on actual hardware yet. |
jnohlgard
left a comment
There was a problem hiding this comment.
The commit message is a bit too long and should start with "kinetis:"
suggestion:
kinetis: Use 9 bit UART configuration for 8E1, 8O1 modes
Shortened commit message and also removed the changes to the pba-d-01-kw2x uart configuration and will make a separate PR. EDIT: updated the PR in order to reflect that the pba-d-01-kw2x uart changes are not part of the PR anymore |
|
Works as expected.
(Of course I adapted the logic analyzer according to the used setting) |
haukepetersen
left a comment
There was a problem hiding this comment.
Seems like I did something wrong when testing my initial PR... ACK and thanks for the fix!
|
@gebart would you approve now? |
Pull request GH-7098 introduced the "8 data bits, even parity, 1 stop bit" mode to the Kinetis UART configuration. Unfortunately, the configuration misses the correct configuration since the current setting reduces the number of actual data bits to 7. Hence, the 9 bit mode needs to be enabled (so it becomes 8 data bits + 1 parity bit).
The following snippet is from the MKW2xD Reference Manual and specifies the required changes.
