cpu/kinetis: make UART mode configurable per board#7098
Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom May 24, 2017
Merged
cpu/kinetis: make UART mode configurable per board#7098haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
Conversation
jnohlgard
approved these changes
May 24, 2017
Member
jnohlgard
left a comment
There was a problem hiding this comment.
Looks good to me, ACK (untested)
| * @{ | ||
| */ | ||
| #define UART_MODE_8N1 (0) | ||
| #define UART_MODE_8E1 (UART_C1_PE_MASK) |
Member
There was a problem hiding this comment.
Add a description for these modes ("8 data bits, 1 stop bit, even parity" etc)
Member
|
Feel free to merge after the documentation content had been addressed |
d07a03a to
867b09c
Compare
Contributor
Author
|
added comments to modes. |
jnohlgard
approved these changes
May 24, 2017
Contributor
Author
|
ACKed and Murdock is happy -> go |
Contributor
|
Have you tested it? Without internet access at home over the long weekend I've had no chance to actually test/review the PR. 😢 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a certain sensor we need the UART run in
8P1mode, so this PR enables this to be configured by the board.