stm32_common: unified RTC driver#6448
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Jan 24, 2017
Merged
Conversation
Contributor
|
Nice ! |
aabadie
requested changes
Jan 23, 2017
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Changes look good out there except a minor copyright thing. I'll try asap on the boards I have here and which cover most of the stm32 family.
cpu/stm32_common/periph/rtc.c
Outdated
| * Copyright (C) 2016 OTA keys S.A. | ||
| * Copyright (C) 2015 Lari Lehtomäki | ||
| * 2016 Laksh Bhatia | ||
| * 2016 OTA keys S.A. |
Contributor
There was a problem hiding this comment.
Maybe 2016-2017 for OTA keys ?
Contributor
|
Tested tests/periph_rtc on a few boards:
|
Contributor
|
I opened #6462 about the crash with the nucleo-l1 which is already in master. |
aabadie
reviewed
Jan 24, 2017
| #include "periph/rtc.h" | ||
| #include "periph_conf.h" | ||
|
|
||
| #if defined(CPU_FAM_STM32F0) || defined(CPU_FAM_STM32F2) || \ |
Contributor
There was a problem hiding this comment.
Why not checking the stm32 F1 family ?
Contributor
the stm32 F1 is not taken into account, why ? |
Member
Author
|
@aabadie the RTC is different on stm32f1 so this driver won't work |
Contributor
|
ok, it makes sense. For the nucleo-l1, we have #6462 for keeping track of the problem (not introduced by this PR). |
Contributor
|
and please squash ;) |
de246fe to
05475f9
Compare
Member
Author
|
Squashed |
Member
|
@aabadie ACK holds? I see green lights!!! |
Contributor
|
So go ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR unify the stm32f0, f2, f3, f4 and l1 RTC driver.
The init behavior is changed a little bit to avoid resetting the counter if the RTC was already enabled.
According to this: http://www.st.com/content/ccc/resource/technical/document/application_note/7a/9c/de/da/84/e7/47/8a/DM00025071.pdf/files/DM00025071.pdf/jcr:content/translations/en.DM00025071.pdf
all these families share (almost) the same RTC.
Tested on f0 and f2 with tests/periph_rtc and default example. Compiled on f3, f4 and l1 (I modified some board to compile the RTC code) but as I don't have any board with these mcu I can't test.