stm32l1/periph/rtc.c: fixed 24-h clock format#6173
Closed
Cr0s wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
stm32l1/periph/rtc.c: fixed 24-h clock format#6173Cr0s wants to merge 1 commit intoRIOT-OS:masterfrom
Cr0s wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Previously there was actually setting of 12-h clock format with comment "Enabling 24-h format". Possibly typo, fixed with according to ST's RTC AN3371: Table 2, row 6.
Contributor
Contributor
|
Tested your fix this afternoon : it indeed works but your branch is quite out-of-date comparing to the current master. Note that the actual master is not working at all : RIOT crashes on nucleo-l1 when running the |
Contributor
|
Another comment : the alarms is triggered 6 times instead of the 4 times mentioned by the test. |
Contributor
|
@Cr0s why? |
Contributor
|
because of #6448 where the same fix is applied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
Previously there was actually setting of 12-h clock format with comment "Enabling 24-h format". Possibly typo, fixed with according to ST's RTC AN3371: Table 2, row 6.
How to check that mistake is present:
If you poll the clock while waiting, you can see transition from 23:59:59 to 24:0:0 without day changing. After applying this fix, the transition becomes from 23:59:59 to 0:0:0 of a next day and alarm will occur 5 seconds later.
Possibly, the same mistake present in STM32F0's RTC driver.
Best regards.