netdev2_tap: fix strange event_callback argument#4859
Merged
OlegHahm merged 1 commit intoRIOT-OS:masterfrom Feb 21, 2016
Merged
netdev2_tap: fix strange event_callback argument#4859OlegHahm merged 1 commit intoRIOT-OS:masterfrom
OlegHahm merged 1 commit intoRIOT-OS:masterfrom
Conversation
7b5d087 to
eb4d985
Compare
Contributor
|
Wow, we're lucky that value never got used. I remember that in the first incarnation of gnrc_netdev2 I used the argument to distinguish ethernet/iee802154/..., but then decided to use layering à la gnrc_netdev2_eth. ACK. |
OlegHahm
added a commit
that referenced
this pull request
Feb 21, 2016
…r-arg netdev2_tap: fix strange event_callback argument
Contributor
|
Now that I'm thinking about it ... The argument is not needed at all. isr_arg is saved within netdev2_t, which is passed to the event_callback. No need to carve out one member and supply it again as argument, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occurrences like this make me wonder if this value if ever checked for
NETDEV2_EVENT_RX_COMPLETE. Some other drivers set it tonetdev->isr_argas this fix does, some leave it NULL.