Skip to content

License pattern fixes#4703

Merged
miri64 merged 3 commits intoRIOT-OS:masterfrom
OlegHahm:license_pattern_fixes
Jan 28, 2016
Merged

License pattern fixes#4703
miri64 merged 3 commits intoRIOT-OS:masterfrom
OlegHahm:license_pattern_fixes

Conversation

@OlegHahm
Copy link
Copy Markdown
Member

fixes #392

@OlegHahm OlegHahm added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: tools Area: Supplementary tools labels Jan 27, 2016
@OlegHahm OlegHahm added this to the FIX ME FIRST milestone Jan 27, 2016
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 27, 2016

ACK and go, when Travis agrees.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

Uhm, are we allowing gplv2 into RIOT now?

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 28, 2016
@OlegHahm
Copy link
Copy Markdown
Member Author

Was there ever a reason against it?

@OlegHahm
Copy link
Copy Markdown
Member Author

I mean for a particular board support or driver it should be okay in a single file.

@kaspar030
Copy link
Copy Markdown
Contributor

Uh, I'm with Ludwig here, for the code that ends up on the board we've been only allowing lgplv2 and compatible so far. For the tools it doesn't matter,

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 28, 2016

@LudwigKnuepfer

Uhm, are we allowing gplv2 into RIOT now?

@kaspar030

Uh, I'm with Ludwig here, for the code that ends up on the board we've been only allowing lgplv2 and compatible so far. For the tools it doesn't matter,

Well, with boards/x86-multiboot-common/include/multiboot.h there is already a GPLv2 file in here ;-)

@Kijewski
Copy link
Copy Markdown
Contributor

Here is a newer release of multiboot.h with an MIT license.

@kaspar030
Copy link
Copy Markdown
Contributor

Well, with boards/x86-multiboot-common/include/multiboot.h there is already a GPLv2 file in here ;-)

Not that the license would matter for a header. ;-)

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 28, 2016

\o/ then let's take out the GPLv2 pattern of this PR and change multiboot with the updated version in another PR.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 28, 2016

@Kijewski are you free to do that?

@Kijewski
Copy link
Copy Markdown
Contributor

@authmillenon, nope not right now, sorry. But ping me if some code needs to be adapted for the new file.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 28, 2016

I have no capabilities right now either… :(

@miri64 miri64 mentioned this pull request Jan 28, 2016
@OlegHahm
Copy link
Copy Markdown
Member Author

Slackers! ;-)

@OlegHahm
Copy link
Copy Markdown
Member Author

Updated the header.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I see this correctly there is no replacement for this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 28, 2016

How can I test this replacement works?

@OlegHahm
Copy link
Copy Markdown
Member Author

I don't know. I simple tried default example on i386-qemu, but the shell seems to be broken anyway.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 28, 2016

Confirmed (might be because it does not implement uart_stdio?). ACK. Please squash

@OlegHahm OlegHahm force-pushed the license_pattern_fixes branch from 9bf5f36 to b5bd1a8 Compare January 28, 2016 15:46
@OlegHahm
Copy link
Copy Markdown
Member Author

squashed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

#ifndef MULTIBOOT_HEADER_CHECKSUM
#define MULTIBOOT_HEADER_CHECKSUM = (-(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS))
#endif

at top of file and still use the macro?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I wrote this intentionally as is to avoid similarities to the GPL version. (I know that legally this is rather useless.)

@LudwigKnuepfer
Copy link
Copy Markdown
Member

The purpose of the license checker is to warn about files with non-compatible licenses.
Of course we are at liberty to ignore this warning in certain situations, but in order to not let RIOT become riddled with non-compatible parts we need the checker to continue warning us.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 28, 2016

Not that the license would matter for a header. ;-)

As far as my copyright knowledge goes (which is not much I have to say) the documentation needs also be freed from the authors copyright via the license. Otherwise, the sole copyright lies with the author and we wouldn't be able to take the documentation for our own. IANAL, but regarding this: yes, license in a header does matter.

@OlegHahm
Copy link
Copy Markdown
Member Author

The purpose of the license checker is to warn about files with non-compatible licenses.

But GPLv2 is compatible with LGPLv2.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 28, 2016

This PR doesn't introduce GPLv2 checks so I merge now.

miri64 added a commit that referenced this pull request Jan 28, 2016
@miri64 miri64 merged commit bc2ee6a into RIOT-OS:master Jan 28, 2016
@OlegHahm OlegHahm deleted the license_pattern_fixes branch January 28, 2016 21:10
@kaspar030
Copy link
Copy Markdown
Contributor

The purpose of the license checker is to warn about files with non-compatible licenses.

But GPLv2 is compatible with LGPLv2.

Have to be careful with those statements. Distributing binaries with GPLv2 inside requires the whole code to be distributed as GPLv2. In this case, GPLv2 is viral. I don't think that's what most people expect when talking about "compatibility" of licenses.

@OlegHahm
Copy link
Copy Markdown
Member Author

Distributing binaries with GPLv2 inside requires the whole code to be distributed as GPLv2.

That's why I wrote "I mean for a particular board support or driver it should be okay in a single file." Particular for the qemu (or native) support, I don't see reasons against GPL.

In this case, GPLv2 is viral.

Is there any case where GPL is not viral?

I don't think that's what most people expect when talking about "compatibility" of licenses.

The stupidity of the mass is not my fault. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clean up license headers

6 participants