Conversation
|
ACK and go, when Travis agrees. |
|
Uhm, are we allowing gplv2 into RIOT now? |
|
Was there ever a reason against it? |
|
I mean for a particular board support or driver it should be okay in a single file. |
|
Uh, I'm with Ludwig here, for the code that ends up on the board we've been only allowing lgplv2 and compatible so far. For the tools it doesn't matter, |
Well, with |
|
Here is a newer release of multiboot.h with an MIT license. |
Not that the license would matter for a header. ;-) |
|
\o/ then let's take out the GPLv2 pattern of this PR and change multiboot with the updated version in another PR. |
|
@Kijewski are you free to do that? |
|
@authmillenon, nope not right now, sorry. But ping me if some code needs to be adapted for the new file. |
|
I have no capabilities right now either… :( |
|
Slackers! ;-) |
|
Updated the header. |
There was a problem hiding this comment.
If I see this correctly there is no replacement for this.
|
How can I test this replacement works? |
|
I don't know. I simple tried |
|
Confirmed (might be because it does not implement |
9bf5f36 to
b5bd1a8
Compare
|
squashed |
There was a problem hiding this comment.
Maybe
#ifndef MULTIBOOT_HEADER_CHECKSUM
#define MULTIBOOT_HEADER_CHECKSUM = (-(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS))
#endif
at top of file and still use the macro?
There was a problem hiding this comment.
Actually, I wrote this intentionally as is to avoid similarities to the GPL version. (I know that legally this is rather useless.)
|
The purpose of the license checker is to warn about files with non-compatible licenses. |
As far as my copyright knowledge goes (which is not much I have to say) the documentation needs also be freed from the authors copyright via the license. Otherwise, the sole copyright lies with the author and we wouldn't be able to take the documentation for our own. IANAL, but regarding this: yes, license in a header does matter. |
But GPLv2 is compatible with LGPLv2. |
|
This PR doesn't introduce GPLv2 checks so I merge now. |
Have to be careful with those statements. Distributing binaries with GPLv2 inside requires the whole code to be distributed as GPLv2. In this case, GPLv2 is viral. I don't think that's what most people expect when talking about "compatibility" of licenses. |
That's why I wrote "I mean for a particular board support or driver it should be okay in a single file." Particular for the qemu (or native) support, I don't see reasons against GPL.
Is there any case where GPL is not viral?
The stupidity of the mass is not my fault. ;) |
fixes #392