Skip to content

uncrustify: ignore parens on return#4481

Merged
cgundogan merged 1 commit intoRIOT-OS:masterfrom
miri64:uncrustify/enh/ignore-return-parens
Jan 26, 2016
Merged

uncrustify: ignore parens on return#4481
cgundogan merged 1 commit intoRIOT-OS:masterfrom
miri64:uncrustify/enh/ignore-return-parens

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Dec 15, 2015

@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Dec 15, 2015
@miri64 miri64 mentioned this pull request Dec 15, 2015
Merged
@Kijewski
Copy link
Copy Markdown
Contributor

Kijewski commented Dec 15, 2015

Against.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Dec 15, 2015

Why?

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Dec 15, 2015

Shouldn't we either go for "add" or "remove"?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Dec 15, 2015

Then stuff like

return (1);

Will pop-up, too.

@DipSwitch
Copy link
Copy Markdown
Member

DipSwitch commented Dec 16, 2015

For what it's worth: I would prefer to use ignore over add or remove, for me the ( helps to inform the reader that it's not just a value return, but contain an expression of some kind. Although I just realized that it might be a bit cryptic... xD

@DipSwitch DipSwitch mentioned this pull request Dec 17, 2015
Closed
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 23, 2016

Any consensus?

@miri64 miri64 added Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 23, 2016
@miri64 miri64 assigned cgundogan and unassigned OlegHahm Jan 25, 2016
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Jan 26, 2016

I am also for ignore here for the same reason @DipSwitch stated above. @Kijewski do you still NACK?

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Jan 26, 2016

I agree with @cgundogan and @DipSwitch, I have the same reasoning as @DipSwitch regarding expression vs. simple value return.

@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Jan 26, 2016

+1 for 'ignore'

@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Jan 26, 2016

and GO

cgundogan added a commit that referenced this pull request Jan 26, 2016
@cgundogan
Merge pull request #4481 from authmillenon/uncrustify/enh/ignore-retu…
e2b9b67 
…rn-parens

uncrustify: ignore parens on return
@cgundogan cgundogan merged commit e2b9b67 into RIOT-OS:master Jan 26, 2016
@miri64 miri64 deleted the uncrustify/enh/ignore-return-parens branch January 26, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cgundogan cgundogan

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@miri64 @Kijewski @OlegHahm @kaspar030 @DipSwitch @cgundogan @jnohlgard @haukepetersen