cpu: make msp430fxyz use uart stdio#3924
Merged
thomaseichinger merged 1 commit intoRIOT-OS:masterfrom Sep 25, 2015
Merged
Conversation
Contributor
Author
|
Without this, everything but shell that using uart is probably broken, and shell loses input echo until "\r" is received. |
a6a8ad4 to
d9414fd
Compare
Contributor
Author
IMHO this fixes a lot of bugs and is a rather trivial change. Should we get it in the release? |
Member
|
Successfully tested on z1 and msb-430h. I'm fine with taking this into this release. |
Member
|
👍 |
Contributor
Author
|
Are those ACKs? Then merge at will. |
Member
|
ACK & Go |
thomaseichinger
added a commit
that referenced
this pull request
Sep 25, 2015
cpu: make msp430fxyz use uart stdio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
msp430fxyz used an ugly-hacked uart_stdio replacement as it was not fast enough to handle bytewise isr-to-thread transfer using ringbuffer at 115kbaud.
Using the improved thread-safe ringbuffer (which avoids interrupt disabling), the msp easily handles higher speeds.
Depends on #3923.