oonf_api: adapt for new sockets by miri64 · Pull Request #3882 · RIOT-OS/RIOT

miri64 · 2015-09-17T10:09:15Z

Adapts oonf_api to use posix_sockets instead of pnet (in pkg/oonf_api/0001-add-RIOT-support.patch) and updates the following patches accordingly.

~~Depends on #3646~~ (merged) for functionality, but should also compile without it.

miri64 · 2015-09-17T10:39:58Z

Rebased to current #3646.

miri64 · 2015-09-17T11:23:34Z

And now it's finally working!

Lotterleben · 2015-09-17T19:45:51Z

Oh boy :D Nice one :) I'm assuming the non-patch files are from a PR this PR depends on? (I'm sorry I'm not very up to speed currently, things have been a bit hectic :S)

Edit: reading properly can go a long way >.< sorry, will have a look.

miri64 · 2015-09-17T21:24:23Z

I'm assuming the non-patch files are from a PR this PR depends on?

Yes this PR is essentially only +80 −337

miri64 · 2015-09-21T13:48:39Z

Rebased to current #3646

miri64 · 2015-09-21T19:54:36Z

Rebased to current #3646

Lotterleben · 2015-09-21T21:35:39Z

pkg/oonf_api/0001-add-RIOT-support.patch

tbh I don't quite get this line :/ If the address family is v4, assume src is a sockaddr_in6 but then set its family to AF_INET instead of AF_INET6?

You are right. That's an error. Will fix!

Errr.... This change removes this line from the patch… reading diffs to diffs is hell :D

aghhh sry :D

miri64 · 2015-09-22T21:10:03Z

Rebased and squashed to current master

haukepetersen · 2015-09-23T16:18:03Z

Whats the state on this? @Lotterleben: were you able to test this? And can you give an ack?

miri64 · 2015-09-23T16:21:52Z

Rebased to current master

miri64 · 2015-09-23T17:18:30Z

To make things easier: here's what this PR does to oonf: The patches changing types for use with socket_base are basically reverted and the only changes made to the oonf_api are now only Makefile and scope_id (which is basically a fancy socket-specific word to say interface) related.

miri64 · 2015-09-23T17:19:34Z

RIOT's POSIX sockets do not support scope_id yet. (for this POSIX net/if.h needs to be implemented and for this we need a stack-common interface API)

Lotterleben · 2015-09-23T19:48:40Z

@haukepetersen I couldn't test it with my AODVv2 packets (still waaay behind on that port... doesnt have sockets again yet ^^), but I'll try with the oonf example app.

haukepetersen · 2015-09-23T20:52:43Z

nice. Lets try to get this in ASAP - as the CC110x driver is almost in, this is pretty much the last thing needed to get the RC out...

Lotterleben · 2015-09-23T22:11:52Z

Martine, were you able to build the exmaple app from within pkg/oonf_api/oonf_api/examples/rfc5444_reader_writer? I'm not sure if this is an error or just me being rusty and stupid.

Edit: I think its the latter. Nevermind me then ^^ Sry

miri64 · 2015-09-23T23:42:14Z

I have to confess that I only tested if examples/default with USEMODULE+="oonf_rfc5444" set was compiling 😞. Will look into the OONF examples too.

miri64 · 2015-09-23T23:43:45Z

oh my god... the makefiles for these are like ten versions out dated Oo will fix.

miri64 · 2015-09-23T23:57:30Z

Mh… all the applications don't seem to use sockets anyway, if I see that correctly. Question is: What do you want to test then?

miri64 · 2015-09-24T00:04:58Z

Adapted example and tests Makefiles (though I don't understand how the mechanism is supposed to work with the tests) and squashed immediately.

OlegHahm · 2015-09-24T11:03:49Z

Let's see what Travis says.

haukepetersen · 2015-09-24T12:18:16Z

Travis is happy -> I would say we merge...

miri64 · 2015-09-24T12:31:20Z

There is no application that actually builds this modules, so I would be very happy if someone at least tries to compile it ;-)

OlegHahm · 2015-09-24T13:36:42Z

pkg/oonf_api/oonf_api/examples/rfc5444_reader_writer/ builds for me on native and on iotlab-m3 if I specify WERROR=0.

miri64 · 2015-09-24T13:44:06Z

Should be enough for now. I'm not willing to fix other peoples errors right now ;-)

oonf_api: adapt for new sockets

OlegHahm · 2015-09-24T13:48:46Z

post ACK

miri64 · 2015-09-24T13:56:31Z

Sorry 😥

miri64 added Area: network Area: Networking Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Sep 17, 2015

miri64 assigned Lotterleben Sep 17, 2015

miri64 added this to the Release 2015.09 milestone Sep 17, 2015

miri64 force-pushed the pkg/clean/oonf_api branch from 32465ed to 8fad5d2 Compare September 17, 2015 10:39

miri64 force-pushed the pkg/clean/oonf_api branch 2 times, most recently from 9b54f64 to bff4a03 Compare September 17, 2015 11:22

miri64 mentioned this pull request Sep 17, 2015

socket_base: remove deprecated header files #3885

Merged

kaspar030 mentioned this pull request Sep 17, 2015

features lost when removing obsolete network stack #3417

Closed

12 tasks

miri64 force-pushed the pkg/clean/oonf_api branch from bff4a03 to 73e58f8 Compare September 17, 2015 21:07

miri64 force-pushed the pkg/clean/oonf_api branch from 73e58f8 to 13b11e2 Compare September 21, 2015 13:48

miri64 force-pushed the pkg/clean/oonf_api branch from 13b11e2 to 48810fa Compare September 21, 2015 19:54

OlegHahm added the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 21, 2015

Lotterleben reviewed Sep 21, 2015
View reviewed changes

miri64 force-pushed the pkg/clean/oonf_api branch from 447b8f0 to d74bb80 Compare September 22, 2015 21:07

miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 22, 2015

miri64 force-pushed the pkg/clean/oonf_api branch from fd3bffc to 63644e1 Compare September 22, 2015 21:22

miri64 force-pushed the pkg/clean/oonf_api branch from 63644e1 to 75b0962 Compare September 23, 2015 16:21

miri64 added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 23, 2015

oonf_api: adapt for new sockets

3536c84

miri64 force-pushed the pkg/clean/oonf_api branch from 75b0962 to 3536c84 Compare September 24, 2015 00:04

miri64 mentioned this pull request Sep 24, 2015

oonf_api: remove trailing white spaces #3704

Closed

miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 24, 2015

OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 24, 2015

miri64 added a commit that referenced this pull request Sep 24, 2015

Merge pull request #3882 from authmillenon/pkg/clean/oonf_api

0008927

oonf_api: adapt for new sockets

miri64 merged commit 0008927 into RIOT-OS:master Sep 24, 2015

miri64 deleted the pkg/clean/oonf_api branch September 24, 2015 13:44

Conversation

miri64 commented Sep 17, 2015

Uh oh!

miri64 commented Sep 17, 2015

Uh oh!

miri64 commented Sep 17, 2015

Uh oh!

Lotterleben commented Sep 17, 2015

Uh oh!

miri64 commented Sep 17, 2015

Uh oh!

miri64 commented Sep 21, 2015

Uh oh!

miri64 commented Sep 21, 2015

Uh oh!

Lotterleben Sep 21, 2015

Choose a reason for hiding this comment

Uh oh!

miri64 Sep 22, 2015

Choose a reason for hiding this comment

Uh oh!

miri64 Sep 22, 2015

Choose a reason for hiding this comment

Uh oh!

Lotterleben Sep 22, 2015

Choose a reason for hiding this comment

Uh oh!

miri64 commented Sep 22, 2015

Uh oh!

haukepetersen commented Sep 23, 2015

Uh oh!

miri64 commented Sep 23, 2015

Uh oh!

miri64 commented Sep 23, 2015

Uh oh!

miri64 commented Sep 23, 2015

Uh oh!

Lotterleben commented Sep 23, 2015

Uh oh!

haukepetersen commented Sep 23, 2015

Uh oh!

Lotterleben commented Sep 23, 2015

Uh oh!

miri64 commented Sep 23, 2015

Uh oh!

miri64 commented Sep 23, 2015

Uh oh!

miri64 commented Sep 23, 2015

Uh oh!

miri64 commented Sep 24, 2015

Uh oh!

OlegHahm commented Sep 24, 2015

Uh oh!

haukepetersen commented Sep 24, 2015

Uh oh!

miri64 commented Sep 24, 2015

Uh oh!

OlegHahm commented Sep 24, 2015

Uh oh!

miri64 commented Sep 24, 2015

Uh oh!

OlegHahm commented Sep 24, 2015

Uh oh!

miri64 commented Sep 24, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants