drivers: add cc110x driver by kaspar030 · Pull Request #3716 · RIOT-OS/RIOT

kaspar030 · 2015-08-26T09:50:02Z

This PR adds a cc110x driver that is based on netdev2 + gnrc.

Tested on msba2. Please note that the wireless parameters are different than with our legacy code, so communication with devices using the old drivers will probably not work.

The gnrc glue code fakes a iee802154 device so sixlowpan can be used in cc110x networks.

Waiting for #3683.

kaspar030 · 2015-08-26T17:49:41Z

rebased

kaspar030 · 2015-09-04T16:52:31Z

rebased

OlegHahm · 2015-09-04T19:51:49Z

boards/msba2/include/cc110x_params.h

Sorry for the nitpick, bu tthe indentation seems off.

OlegHahm · 2015-09-04T19:56:00Z

~~Which packet size does this driver support?~~ Found it.

OlegHahm · 2015-09-04T19:57:41Z

drivers/cc110x/cc110x-netdev2.c

Why do we have this here but not at similar places?

leftover, will remove.

OlegHahm · 2015-09-04T20:02:32Z

Sorry for the superficial review so far - will test asap. Well documented though.

OlegHahm · 2015-09-04T20:04:45Z

Could you add the avsextrem (and maybe pttu) as well?

OlegHahm · 2015-09-04T20:08:41Z

drivers/include/cc110x/cc110x-internal.h

C style comments here, too.

haukepetersen · 2015-09-10T14:39:07Z

drivers/include/cc110x/cc110x-interface.h

the the without MAC still true?

also just leave the @ingroup drivers_cc110x and remove the rest

OlegHahm · 2015-09-14T14:54:38Z

@kaspar030, planning to address the comments?

kaspar030 · 2015-09-14T14:56:35Z

@OlegHahm Yes, but I want to finish #3525 first.

OlegHahm · 2015-09-14T14:58:21Z

Sure, just checking.

kaspar030 · 2015-09-23T11:51:34Z

addressed most comments
rebased

The gnrc part of this drivers doesn't play well, yet, with sixlowpan. The crude adaption layer needs some work.

For the node ID, what's the current state of the art for getting a random or node-unique number?

kaspar030 · 2015-09-23T15:55:55Z

update When disabling IPHC, together with #3944, I can ping between two msba2's.

@authmillenon Do you know any reason why IPHC might break? I suspect it's because of the 1 byte hardware addresses...

miri64 · 2015-09-23T16:05:46Z

@authmillenon Do you know any reason why IPHC might break? I suspect it's because of the 1 byte hardware addresses...

I took special care that it would work with 1-byte addresses, but never tested it (duh). So there might still be some hidden issues.

kaspar030 · 2015-09-23T17:03:01Z

squashed

kaspar030 · 2015-09-23T17:39:48Z

waiting for cpu: lpc2387: add spi_conf_pins() #3946.

haukepetersen · 2015-09-23T20:49:51Z

not anymore...

haukepetersen · 2015-09-23T20:50:38Z

kicked Travis

OlegHahm · 2015-09-23T21:47:33Z

Do we have an ACK somewhere?

haukepetersen · 2015-09-24T08:52:23Z

let me look over this once more, then you'll have it!

haukepetersen · 2015-09-24T09:49:37Z

Looks good. ACK and go.

drivers: add cc110x driver

kaspar030 added Area: network Area: Networking State: waiting for other PR State: The PR requires another PR to be merged first Area: drivers Area: Device drivers labels Aug 26, 2015

kaspar030 assigned OlegHahm Aug 26, 2015

kaspar030 added this to the Release 2015.08 milestone Aug 26, 2015

kaspar030 force-pushed the ng_cc110x branch from c065457 to dd2b355 Compare August 26, 2015 17:49

kaspar030 force-pushed the ng_cc110x branch 2 times, most recently from bf826b5 to c9387f5 Compare September 3, 2015 16:30

kaspar030 force-pushed the ng_cc110x branch from c9387f5 to e69de8f Compare September 4, 2015 16:52

kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Sep 4, 2015

OlegHahm reviewed Sep 4, 2015
View reviewed changes

boards/msba2/include/cc110x_params.h Outdated

Copy link
Copy Markdown

Member

OlegHahm Sep 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the nitpick, bu tthe indentation seems off.

OlegHahm reviewed Sep 4, 2015
View reviewed changes

drivers/include/cc110x/cc110x-internal.h Outdated

Copy link
Copy Markdown

Member

OlegHahm Sep 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C style comments here, too.

haukepetersen reviewed Sep 10, 2015
View reviewed changes

kaspar030 mentioned this pull request Sep 22, 2015

features lost when removing obsolete network stack #3417

Closed

12 tasks

kaspar030 force-pushed the ng_cc110x branch from ebc9c52 to 779d6ad Compare September 23, 2015 11:45

kaspar030 force-pushed the ng_cc110x branch from 6f8157c to b670350 Compare September 23, 2015 16:39

kaspar030 added 2 commits September 23, 2015 18:55

drivers: add cc110x driver

14d0ef6

boards: msba2: add cc110x support

63acf0b

kaspar030 force-pushed the ng_cc110x branch from b670350 to 63acf0b Compare September 23, 2015 17:02

kaspar030 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 23, 2015

kaspar030 added the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 23, 2015

kaspar030 mentioned this pull request Sep 23, 2015

cpu: lpc2387: add spi_conf_pins() #3946

Merged

OlegHahm removed the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 23, 2015

haukepetersen added a commit that referenced this pull request Sep 24, 2015

Merge pull request #3716 from kaspar030/ng_cc110x

7cb3f9b

drivers: add cc110x driver

haukepetersen merged commit 7cb3f9b into RIOT-OS:master Sep 24, 2015

kaspar030 deleted the ng_cc110x branch February 7, 2017 22:13

Conversation

kaspar030 commented Aug 26, 2015

Uh oh!

kaspar030 commented Aug 26, 2015

Uh oh!

kaspar030 commented Sep 4, 2015

Uh oh!

OlegHahm Sep 4, 2015

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Sep 4, 2015

Uh oh!

OlegHahm Sep 4, 2015

Choose a reason for hiding this comment

Uh oh!

kaspar030 Sep 4, 2015

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Sep 4, 2015

Uh oh!

OlegHahm commented Sep 4, 2015

Uh oh!

OlegHahm Sep 4, 2015

Choose a reason for hiding this comment

Uh oh!

haukepetersen Sep 10, 2015

Choose a reason for hiding this comment

Uh oh!

haukepetersen Sep 10, 2015

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Sep 14, 2015

Uh oh!

kaspar030 commented Sep 14, 2015

Uh oh!

OlegHahm commented Sep 14, 2015

Uh oh!

kaspar030 commented Sep 23, 2015

Uh oh!

kaspar030 commented Sep 23, 2015

Uh oh!

miri64 commented Sep 23, 2015

Uh oh!

kaspar030 commented Sep 23, 2015

Uh oh!

kaspar030 commented Sep 23, 2015

Uh oh!

haukepetersen commented Sep 23, 2015

Uh oh!

haukepetersen commented Sep 23, 2015

Uh oh!

OlegHahm commented Sep 23, 2015

Uh oh!

haukepetersen commented Sep 24, 2015

Uh oh!

haukepetersen commented Sep 24, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants