Skip to content

icmpv6: remove superfluous header build functions#3693

Merged
cgundogan merged 1 commit intoRIOT-OS:masterfrom
OlegHahm:remove_superfluous_icmpv6_hdr_build_functions
Oct 27, 2015
Merged

icmpv6: remove superfluous header build functions#3693
cgundogan merged 1 commit intoRIOT-OS:masterfrom
OlegHahm:remove_superfluous_icmpv6_hdr_build_functions

Conversation

@OlegHahm
Copy link
Copy Markdown
Member

These functions seem unnecessary and only one of them was actually used at only one place.

@OlegHahm OlegHahm added Area: network Area: Networking Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. labels Aug 22, 2015
@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 22, 2015

Mh… I don't like it, they are after all inline-functions, and as a bonus help people, that don't know much about the headers to build them.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 22, 2015

Can you show me a bin-diff, that this actually brings any advantage?

@OlegHahm
Copy link
Copy Markdown
Member Author

I argue that these inline functions bring any advantage for no-one.

@OlegHahm
Copy link
Copy Markdown
Member Author

This PR tries not optimize code size but keep the API slim and I don't see any advantage in a do_foo_xyz(..-) function as a wrapper for do_foo(xyz, ...).

@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 22, 2015

I see it, because it is convenient (at least for me).

@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 22, 2015

If we do it your way, gnrc_icmpv6_echo_build() would need a check if the type is correct btw.

@OlegHahm
Copy link
Copy Markdown
Member Author

I don't see the necessity for that. Whoever calls this function should not what she/he's doing.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 25, 2015

I think this is a point of contention between us. If you want this merged, I think you have to reassign :D

@cgundogan
Copy link
Copy Markdown
Member

Did anyone of you had a change of heart since the last discussion? Personally, I also would let go of the inlined wrapper functions and opt for a slimmer API. So ACK from my side

@cgundogan cgundogan added Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 27, 2015
@miri64
Copy link
Copy Markdown
Member

miri64 commented Oct 27, 2015

I still think it is inconvenient, but since it seems that I'm overruled let's do it.

@cgundogan
Copy link
Copy Markdown
Member

travis approves and everybody seems to be happy. GO

cgundogan added a commit that referenced this pull request Oct 27, 2015
…build_functions

icmpv6: remove superfluous header build functions
@cgundogan cgundogan merged commit c175273 into RIOT-OS:master Oct 27, 2015
@OlegHahm OlegHahm deleted the remove_superfluous_icmpv6_hdr_build_functions branch October 27, 2015 19:06
@miri64
Copy link
Copy Markdown
Member

miri64 commented Oct 27, 2015

I'm not happy, I'm just complying to an argument I'm tired of having :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants