icmpv6: remove superfluous header build functions#3693
Conversation
|
Mh… I don't like it, they are after all inline-functions, and as a bonus help people, that don't know much about the headers to build them. |
|
Can you show me a bin-diff, that this actually brings any advantage? |
|
I argue that these inline functions bring any advantage for no-one. |
|
This PR tries not optimize code size but keep the API slim and I don't see any advantage in a |
|
I see it, because it is convenient (at least for me). |
|
If we do it your way, |
|
I don't see the necessity for that. Whoever calls this function should not what she/he's doing. |
|
I think this is a point of contention between us. If you want this merged, I think you have to reassign :D |
|
Did anyone of you had a change of heart since the last discussion? Personally, I also would let go of the inlined wrapper functions and opt for a slimmer API. So ACK from my side |
|
I still think it is inconvenient, but since it seems that I'm overruled let's do it. |
|
travis approves and everybody seems to be happy. GO |
…build_functions icmpv6: remove superfluous header build functions
|
I'm not happy, I'm just complying to an argument I'm tired of having :P |
These functions seem unnecessary and only one of them was actually used at only one place.