Skip to content

ng_ipv6: fix write protect#3498

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:ng_ipv6/fix/write-protect
Jul 28, 2015
Merged

ng_ipv6: fix write protect#3498
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:ng_ipv6/fix/write-protect

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Jul 26, 2015

For sending the try to duplicate of the IPv6 header for write protection happens currently before it is checked if the first header is the IPv6 header, resulting in the netif header being duplicated instead. While this is also needed (for the removal of the header in _send_unicast) it leaves the IPv6 header unprotected. This fixes this issue.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking NSTF labels Jul 26, 2015
@miri64 miri64 added this to the Release 2015.06 milestone Jul 26, 2015
@miri64 miri64 mentioned this pull request Jul 26, 2015
Merged
@miri64 miri64 added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Jul 27, 2015
@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 27, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jul 27, 2015

ACK

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jul 27, 2015

@authmillenon please squash

@OlegHahm OlegHahm added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 27, 2015
@miri64 miri64 force-pushed the ng_ipv6/fix/write-protect branch from 7c049f9 to 2645833 Compare July 28, 2015 07:42
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jul 28, 2015

Squashed

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Jul 28, 2015
miri64 added a commit that referenced this pull request Jul 28, 2015
@miri64
Merge pull request #3498 from authmillenon/ng_ipv6/fix/write-protect
a583482 
ng_ipv6: fix write protect
@miri64 miri64 merged commit a583482 into RIOT-OS:master Jul 28, 2015
@miri64 miri64 deleted the ng_ipv6/fix/write-protect branch July 28, 2015 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@OlegHahm OlegHahm

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2015.09

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @OlegHahm @PeterKietzmann