Skip to content

mulle: Initialize NVRAM storage at boot, update boot counter#3485

Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/mulle-nvram
Oct 21, 2015
Merged

mulle: Initialize NVRAM storage at boot, update boot counter#3485
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/mulle-nvram

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

Add initialization of the on-board NVRAM chip, and write a 32 bit boot counter to the NVRAM on each boot.

Also includes a cleanup commit for removing some leftovers from the unification of Cortex-M platform code.

@jnohlgard jnohlgard added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jul 23, 2015
@PeterKietzmann
Copy link
Copy Markdown
Member

@gebart I think it could take some days until I'll review this PR. Are there any other volunteers?

@benoit-canet
Copy link
Copy Markdown
Contributor

@gebart : Are the schematics of this device availlable ?

@PeterKietzmann
Copy link
Copy Markdown
Member

@benoit-canet please comment inside the PR, not in the commit (compare Developement Procedures point 5.). And btw: Thanks for reviewing. AFAIK @gebart is on holiday until the next week. I assume you already found the mulle wiki?

@jnohlgard
Copy link
Copy Markdown
Member Author

@benoit-canet Thank you for reviewing.

The schematics of the board are not publicly available, but https://github.com/eistec/mulle/wiki/Mulle-board-overview contains a short description of the on-board devices.

@jnohlgard
Copy link
Copy Markdown
Member Author

  • check return value of mulle_nvram_init
  • added todo comment about hwtimer_init
  • added comment on why Vperiph has to be turned on early
  • rebased

@benoit-canet
Copy link
Copy Markdown
Contributor

#define MULLE_NVRAM_SPI_DEV SPI_2 /**< FRAM SPI bus */

Please add a comment mentioning that SPI_2 is mapped to SPI0 in RIOT because comparing this line with the wiki is confusing. (The only hint is burried in a header)

The cleanup middle commit does two very differents things (initializing different path and removing code) it should be split in two.

Ack once this is done.

@PeterKietzmann
Copy link
Copy Markdown
Member

@gebart will you adapt @benoit-canet 's proposed changes and rebase?

@jnohlgard
Copy link
Copy Markdown
Member Author

Will update this later, I will be kind of busy the next two weeks or so

@PeterKietzmann
Copy link
Copy Markdown
Member

OKay. Just saw that @benoit-canet already ACKed this one (when small change and cleanup is done)

@PeterKietzmann
Copy link
Copy Markdown
Member

@gebart could you please squash (at least the latest commit) so we can run Travis.

@jnohlgard jnohlgard force-pushed the pr/mulle-nvram branch 2 times, most recently from 619af8e to 0f819c0 Compare October 4, 2015 17:12
@jnohlgard
Copy link
Copy Markdown
Member Author

rebased, added a comment about SPI_2 being mapped to hardware SPI0 and immediately squashed. The cleanup of the old files was merged as a separate PR.

@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 4, 2015
The boot counter is incremented on each boot. Still missing is an
interface for reading the boot counter from an application.
@jnohlgard
Copy link
Copy Markdown
Member Author

added extern "C" to mulle-nvram.h and immediately squashed.

@PeterKietzmann
Copy link
Copy Markdown
Member

I dare to hit the button now. And go

PeterKietzmann added a commit that referenced this pull request Oct 21, 2015
mulle: Initialize NVRAM storage at boot, update boot counter
@PeterKietzmann PeterKietzmann merged commit fc53957 into RIOT-OS:master Oct 21, 2015
@jnohlgard jnohlgard deleted the pr/mulle-nvram branch October 22, 2015 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants