Skip to content

ng_sixlopan_iphc: Multicast decoding 8-bit fix and build fix#3435

Merged
jnohlgard merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/iphc-mcast-8bit
Jul 20, 2015
Merged

ng_sixlopan_iphc: Multicast decoding 8-bit fix and build fix#3435
jnohlgard merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/iphc-mcast-8bit

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard commented Jul 17, 2015

decoding mcast 8 bit format was wrong, it took 16 bits from the packet.
also fixes the compile error introduced by #3143 for the initialization of eui64_t

@jnohlgard jnohlgard added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking NSTF labels Jul 17, 2015
miri64
miri64 reviewed Jul 18, 2015
View reviewed changes
sys/net/network_layer/ng_sixlowpan/iphc/ng_sixlowpan_iphc.c Outdated
Copy link
Copy Markdown
Member

@miri64 miri64 Jul 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adapt this comment accordingly please.

Copy link
Copy Markdown
Member Author

@jnohlgard jnohlgard Jul 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@miri64 miri64 mentioned this pull request Jul 18, 2015
Merged
@jnohlgard
Copy link
Copy Markdown
Member Author

jnohlgard commented Jul 20, 2015

Comments addressed, OK to squash?

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Jul 20, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jul 20, 2015

In accordance with https://tools.ietf.org/html/rfc6282#section-3.1.1 this seems to be a proper change: ACK

@jnohlgard jnohlgard force-pushed the pr/iphc-mcast-8bit branch from 6a32dfd to 2804683 Compare July 20, 2015 08:09
@jnohlgard
Copy link
Copy Markdown
Member Author

jnohlgard commented Jul 20, 2015

squashed

@jnohlgard jnohlgard added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Jul 20, 2015
@jnohlgard jnohlgard force-pushed the pr/iphc-mcast-8bit branch from 2804683 to f15a539 Compare July 20, 2015 10:35
jnohlgard pushed a commit that referenced this pull request Jul 20, 2015
Merge pull request #3435 from gebart/pr/iphc-mcast-8bit
1bfe635 
ng_sixlopan_iphc: Multicast decoding 8-bit fix and build fix
@jnohlgard jnohlgard merged commit 1bfe635 into RIOT-OS:master Jul 20, 2015
@jnohlgard jnohlgard deleted the pr/iphc-mcast-8bit branch July 20, 2015 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@miri64 miri64

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnohlgard @OlegHahm @miri64