Skip to content

native: periph/timer: prevent underflow in timer_set_absolute#3344

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:fix_native_timer_possible_underflow
Jul 9, 2015
Merged

native: periph/timer: prevent underflow in timer_set_absolute#3344
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:fix_native_timer_possible_underflow

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

timer_set_absolute() could underflow when being called with a very small delta between now and the target time. This catches all deltas smaller NATIVE_TIMER_MIN_RES.

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: native Platform: This PR/issue effects the native platform labels Jul 9, 2015
@kaspar030 kaspar030 force-pushed the fix_native_timer_possible_underflow branch from 560020e to ec441e9 Compare July 9, 2015 13:24
@PeterKietzmann PeterKietzmann added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 9, 2015
@PeterKietzmann
Copy link
Copy Markdown
Member

I see green lights

@benoit-canet
Copy link
Copy Markdown
Contributor

I understand now
ACK

@kaspar030
Copy link
Copy Markdown
Contributor Author

and go!

kaspar030 added a commit that referenced this pull request Jul 9, 2015
…erflow

native: periph/timer: prevent underflow in timer_set_absolute
@kaspar030 kaspar030 merged commit d15f099 into RIOT-OS:master Jul 9, 2015
@kaspar030 kaspar030 deleted the fix_native_timer_possible_underflow branch July 9, 2015 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants