unittests: don't powerdown node at the end#3309
Conversation
|
What was the rationale for that? |
|
What was the rational for shutting it down? It's handy for native, but most other boards to my observence shut down before the output is complete. |
|
Somewhere in the back of my head I remember that there was at some point already about this behavior. @LudwigOrtmann, @Kijewski, @kaspar030, do you recall anything? @phiros, @gebart, do you have an opinion? |
|
I don't recall, but git blames @authmillenon as the author of the shutdown. ;) I am in favor of the PR, because the powerdown in here is quite arbitrary and forces you to implement LPM in order to run the test suite if I am not mistaken. |
|
@Kijewski I know that, I just don't know exactly why I did it any more... Probably out of inexperience :) |
|
Something about "handy with native" is the only thing I can come up with as well. |
|
I have no opinion on this one, so I re-assign. |
a5a8a50 to
4fb7939
Compare
|
Rebased and adapted to current master. |
|
Note that at least for |
When started 'by hand', |
|
Yes, if it fails from time to time. This seems to be a problem with |
|
I'm just asking because in an other test I experienced a significant impact by |
|
ACK! |
|
This seems to be an issue with the openocd version btw. On my arch machine I do not encounter this problem as much. |
This can be. |
unittests: don't powerdown node at the end
|
Apparently this PR did more than the title says. @authmillenon, can you remember what was the exact problem with pexpect in Ubuntu? |
|
The processes in the children's process group will not be killed causing the older instances to be open in background. |
This currently only works for default output and
OUTPUT=TEXT, but since we don't useOUTPUT=COMPILEandOUTPUT=XMLanyways we should be fine.