Skip to content

ng_net: add IID option and simplify upper layers accordingly#3159

Merged
miri64 merged 9 commits intoRIOT-OS:masterfrom
miri64:ng_net/feat/iid
Jul 1, 2015
Merged

ng_net: add IID option and simplify upper layers accordingly#3159
miri64 merged 9 commits intoRIOT-OS:masterfrom
miri64:ng_net/feat/iid

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Jun 3, 2015

This puts the IPv6 IID generation from the link-layer address where it belongs: into the link-layer.

Overview:

  • introducing a new option for this NETCONF_OPT_IPV6_IID
  • introducing a function ng_xxx_get_iid() per supported link layer (ng_ieee802154 and ng_ethernet).
  • adapting the current ng_ drivers to support the NETCONF_OPT_IPV6_IID option via their respective link layer's ng_xxx_get_iid()
  • adapting ng_ipv6_netif to use NETCONF_OPT_IPV6_IID for IPv6 addresse initialization
  • adapting ng_sixlowpan_iphc to use NETCONF_OPT_IPV6_IID for source address (de)compression and ng_ieee802154_get_iid() for destination address (de)compression

Depends on #3158.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation NSTF labels Jun 3, 2015
@miri64 miri64 added this to the Release 2015.06 milestone Jun 3, 2015
@miri64 miri64 force-pushed the ng_net/feat/iid branch from 2a48c31 to f7f4e0b Compare June 3, 2015 16:52
@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 3, 2015
@miri64 miri64 force-pushed the ng_net/feat/iid branch from f7f4e0b to 557e23b Compare June 3, 2015 17:02
@miri64 miri64 mentioned this pull request Jun 3, 2015
Merged
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Jun 11, 2015

is it really necessary to depend on #3158 ?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jun 11, 2015

Yes, otherwise this fix isn't working for xbee.

@miri64 miri64 force-pushed the ng_net/feat/iid branch from 557e23b to f183197 Compare June 15, 2015 10:32
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jun 15, 2015

Rebased to current master. No more dependent on other PRs

@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 15, 2015
@miri64 miri64 mentioned this pull request Jun 24, 2015
Closed
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jun 30, 2015

Potential Hack'n'ACK candidate or too big?

@miri64 miri64 added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Jun 30, 2015
@miri64 miri64 closed this Jun 30, 2015
@miri64 miri64 reopened this Jun 30, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jun 30, 2015

I would say yes.

@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Jun 30, 2015

Tested on native and samr21-xpro. ipv6 addresses are initialized correctly. GO when travis is happy.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 30, 2015
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Jul 1, 2015

BTW before I merge this: does this still depend on #3158? Shouldn't this be merged first then?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jul 1, 2015

#3158 is already merged...

miri64 added a commit that referenced this pull request Jul 1, 2015
@miri64
Merge pull request #3159 from authmillenon/ng_net/feat/iid
3238ccd 
ng_net: add IID option and simplify upper layers accordingly
@miri64 miri64 merged commit 3238ccd into RIOT-OS:master Jul 1, 2015
@miri64 miri64 deleted the ng_net/feat/iid branch July 1, 2015 10:47
@miri64 miri64 mentioned this pull request Jul 1, 2015
Merged
miri64 added a commit to miri64/RIOT that referenced this pull request Jul 2, 2015
@miri64
[SQUASH ME] update for changes RIOT-OS#3159
531fb64
@miri64 miri64 mentioned this pull request Jul 2, 2015
Merged
@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cgundogan cgundogan

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2015.09

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @cgundogan @PeterKietzmann