icmpv6: add ability to add listed payload in ng_icmpv6_build#2964
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom May 12, 2015
Merged
icmpv6: add ability to add listed payload in ng_icmpv6_build#2964miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
Member
There was a problem hiding this comment.
Just a matter of taste, but I would expect the payload argument after the arguments for the header fields. If you disagree, I won't object and ACK.
Member
Author
There was a problem hiding this comment.
Can I disagree out of lazyness to fix that in downstream PRs?
miri64
added a commit
that referenced
this pull request
May 12, 2015
icmpv6: add ability to add listed payload in ng_icmpv6_build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since options in NDP are a little bit more versatile than a simple payload, I thought it would be simpler to use the possibilities of the packet buffer here ;-)