Add POSIX compatible case insensitive compare#290
Merged
OlegHahm merged 2 commits intoRIOT-OS:masterfrom Nov 4, 2013
Merged
Conversation
Closed
sys/posix/strings.c
Outdated
Contributor
There was a problem hiding this comment.
The return is missing. :)
Member
|
Doxygen documentation for the header file is missing. |
Member
Author
|
Done and rebased to master |
sys/posix/strings.c
Outdated
Contributor
There was a problem hiding this comment.
I'd say why bother? Gcc+Clang give you "__builtin_ffs" which should result in good machine code for any arch.
Member
Author
There was a problem hiding this comment.
Taken into account in 5b4955c
Member
|
ACK |
Member
Author
|
Last change only rebased and formatted comments according to PR #251 |
Member
|
In this case, my ACK still holds. ;) |
Contributor
|
ACK |
OlegHahm
added a commit
that referenced
this pull request
Nov 4, 2013
Add POSIX compatible case insensitive compare
thomaseichinger
pushed a commit
to thomaseichinger/RIOT
that referenced
this pull request
Dec 9, 2013
Add POSIX compatible case insensitive compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for libcoap