Skip to content

ng_ipv6_ext: initial import of extension header handling (including RPL SRH)#2898

Merged
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:ng_ipv6_ext/feat/initial
May 26, 2015
Merged

ng_ipv6_ext: initial import of extension header handling (including RPL SRH)#2898
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:ng_ipv6_ext/feat/initial

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Apr 30, 2015

Based on #2555 (merged).

@miri64 miri64 added Type: new feature The issue requests / The PR implemements a new feature for RIOT NSTF labels Apr 30, 2015
@miri64 miri64 added this to the Network Stack Task Force milestone Apr 30, 2015
This was referenced Apr 30, 2015
Closed
Closed
@miri64 miri64 force-pushed the ng_ipv6_ext/feat/initial branch from e60c851 to 8383954 Compare May 1, 2015 11:56
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 1, 2015

Rebased to current master

cgundogan
cgundogan reviewed May 4, 2015
View reviewed changes
sys/include/net/ng_ipv6/ext.h Outdated
Copy link
Copy Markdown
Member

@cgundogan cgundogan May 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either remove a or make headers singular

@cgundogan cgundogan added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 11, 2015
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented May 11, 2015

I invite you to squash now (:

@miri64 miri64 force-pushed the ng_ipv6_ext/feat/initial branch from 90d3aaf to 0eadaf6 Compare May 11, 2015 20:03
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 11, 2015

Squashed

@cgundogan cgundogan removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 11, 2015
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented May 11, 2015

GO when travis shows green

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented May 12, 2015

Am I the only one where https://travis-ci.org/RIOT-OS/RIOT/pull_requests is not loading properly?

@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented May 12, 2015

@OlegHahm the site is also not loading properly for me.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 12, 2015

They updated yesterday night so that might be the reason

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented May 12, 2015

Seems to be working again.

@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented May 12, 2015

@authmillenon, one more thing before the final merge: can you change the last commit message /rpl/ng_rpl/ ?

@miri64 miri64 force-pushed the ng_ipv6_ext/feat/initial branch from 0eadaf6 to 35cf9bf Compare May 12, 2015 16:41
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 12, 2015

done

@miri64 miri64 force-pushed the ng_ipv6_ext/feat/initial branch from 35cf9bf to abc0280 Compare May 17, 2015 19:52
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 17, 2015

Rebased and adapted to current master, please re-review.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 22, 2015

Kicked travis... @cgundogan ping?

@cgundogan cgundogan mentioned this pull request May 22, 2015
Merged
5 tasks
OlegHahm
OlegHahm reviewed May 26, 2015
View reviewed changes
sys/net/network_layer/ng_ipv6/ext/ng_ipv6_ext.c
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm May 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exit early on null parameter

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented May 26, 2015

Apart from comment: untested re-ACK

miri64 added a commit that referenced this pull request May 26, 2015
@miri64
Merge pull request #2898 from authmillenon/ng_ipv6_ext/feat/initial
e3bdc53 
ng_ipv6_ext: initial import of extension header handling (including RPL SRH)
@miri64 miri64 merged commit e3bdc53 into RIOT-OS:master May 26, 2015
@miri64 miri64 deleted the ng_ipv6_ext/feat/initial branch May 26, 2015 18:16
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 26, 2015

Will fix the comment in follow-up. No patience to wait for travis again.

@miri64 miri64 mentioned this pull request May 26, 2015
Merged
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented May 26, 2015

See #3074

@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cgundogan cgundogan

Labels

Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Network Stack Task Force

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @cgundogan @OlegHahm