Skip to content

sys/shell: removed route to show the RPL internal routing table#2782

Closed
BytesGalore wants to merge 1 commit intoRIOT-OS:masterfrom
BytesGalore:fib_adjust_shell_commands
Closed

sys/shell: removed route to show the RPL internal routing table#2782
BytesGalore wants to merge 1 commit intoRIOT-OS:masterfrom
BytesGalore:fib_adjust_shell_commands

Conversation

@BytesGalore
Copy link
Copy Markdown
Member

With the introduction of the FIB, RPL will eventually (#2765) use it to store the discovered next-hops.
This PR removes the route command that accesses the RPL internal routing table.

@BytesGalore BytesGalore added Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Apr 10, 2015
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file are rather unrelated to the PR description, but they only fix a warning regarding return values.
So if there are no objections I would leave them inside and not open a new PR.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved it to a separate commit (#2812)

BytesGalore pushed a commit to BytesGalore/RIOT that referenced this pull request Apr 10, 2015
@OlegHahm
Copy link
Copy Markdown
Member

So, this should be merged after #2765, right? How about adding the corresponding dependency label?

@BytesGalore
Copy link
Copy Markdown
Member Author

Basically its the other way around the other #2765 should be merged after this is merged since I want to remove this commit :) .I added a label there

@OlegHahm
Copy link
Copy Markdown
Member

Nevertheless they should be merged more or less at the same time to ensure that we don't have a state without a route lookup command for a long time.

@BytesGalore
Copy link
Copy Markdown
Member Author

@OlegHahm definitely, a short time distance between the both would be very beneficial :)

@cgundogan
Copy link
Copy Markdown
Member

ACK as soon as #2765 has been reviewed and ACked, too

BytesGalore pushed a commit to BytesGalore/RIOT that referenced this pull request Apr 13, 2015
BytesGalore pushed a commit to BytesGalore/RIOT that referenced this pull request Apr 14, 2015
BytesGalore pushed a commit to BytesGalore/RIOT that referenced this pull request Apr 14, 2015
@BytesGalore BytesGalore force-pushed the fib_adjust_shell_commands branch 2 times, most recently from 298e43e to 5be4e36 Compare April 20, 2015 09:37
@BytesGalore BytesGalore force-pushed the fib_adjust_shell_commands branch from 5be4e36 to ee1c149 Compare April 27, 2015 05:40
BytesGalore pushed a commit to BytesGalore/RIOT that referenced this pull request Apr 27, 2015
BytesGalore pushed a commit to BytesGalore/RIOT that referenced this pull request Apr 28, 2015
BytesGalore pushed a commit to BytesGalore/RIOT that referenced this pull request May 4, 2015
@BytesGalore BytesGalore force-pushed the fib_adjust_shell_commands branch from ee1c149 to ca19ec0 Compare May 11, 2015 07:30
BytesGalore pushed a commit to BytesGalore/RIOT that referenced this pull request Jul 15, 2015
BytesGalore pushed a commit to BytesGalore/RIOT that referenced this pull request Jul 20, 2015
@cgundogan
Copy link
Copy Markdown
Member

this PR is obsolete now, because it references the former nework stack

@cgundogan cgundogan closed this Aug 17, 2015
@BytesGalore BytesGalore deleted the fib_adjust_shell_commands branch November 2, 2015 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants