sys: net: ng_pktdump: make pktdump have higher-than-main priority#2774
Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom Apr 9, 2015
Merged
sys: net: ng_pktdump: make pktdump have higher-than-main priority#2774PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
Author
There was a problem hiding this comment.
Does a higher priority hurt? The lower one breaks all native shell tests that use getchar (I think), like the tapnet test you wrote.
Member
There was a problem hiding this comment.
Can't tell right now if I experienced the same… In what manner does it break it? Does it starve out due to getchar?
Contributor
Author
There was a problem hiding this comment.
Looks like. Didn't debug further as raising the priority helps and main() sits in shell.
The effect is that the pktdump loop never starts, thus no packets get printed. I think it even stalled the nomac thread.
Member
|
ACK if travis is happy |
Member
|
He is, go! |
PeterKietzmann
added a commit
that referenced
this pull request
Apr 9, 2015
sys: net: ng_pktdump: make pktdump have higher-than-main priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the simple shell implementations seem to be busy-waiting, causing pktdump to never print anything.
This commit fixes those cases by having pktdump a high-than-main priority.